Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the
unsafe
frominit()
that was added in #8. There are two things to consider here:IME
, for the same reasons set forth in Shared global state provides synchronization issues #4, but the fact that this code can overwrite data set by other code is not technically a data race, and therefore notunsafe
.IME
when setting the logger and max level, making those calls safe. This is what all user code should have done after Markinit()
as anunsafe
function. #8 anyways (and before, since apparently the log initialization functions were likely not working correctly prior tolog 0.4.19
), so it makes more sense to simply handle it here.