-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support github actions for the asio-juce branch #120
Conversation
Hey just a heads up, Wizard and I are likely to get around to this over the weekend, but there needs to be a couple changes. For licensing problems with the steinberg sdk you'll want to try to automate the build against: https://github.com/Andersama/JUCE/tree/open_asio_juce Shouldn't require the steinberg sdk, also if possible squash all your commits into one (if not we'll likely end up doing that anyway). |
* update ObsPluginHelpers.cmake * update cmake dir * add buildspec.json * add .cmake-format.json
* use Qt6 * fetch some SDKs (JUCE, asio-sdk) * setup_plugin_target() * add missing resource.rc.in and use it * suppress warnings, check C4596 as warning
OK. now the
and many fixes have been rebased to show this PR briefly (might be rebased again after all hunks are reviewed carefully, as you wish.) New builds are available here: |
Ah I forgot I had to modify Juce furthur, @wkpark the kAsioCanReportOverload value we never found, we only found a reference to the name*. Do you have a source for where that value came from that isn't from the steinberg sdk? I think that would bring the openasio wrapper into full compatibility with the asio standard because I think that was the only thing missing. It also might be the the source for some people's issue with crackling / popping. Worst case I remove the conditional check which is how the plugin was originally built. Second, does the FetchContent_Declare cmake thing not work for building a branch of juce directly? I'd rather just do that over having bash / shell scripting to move things around. |
I've found
you mean the I've just seen your last fix so I'll fix/rebase it soon again. |
Unfortunately that link won't work as a source, it's a doxygen doc of the steinberg sdk. Dead give away is that I've seen plenty of doxygen docs of the thing and the reference to "iasiodrv.h". Funny I played around with carla for a while because it was a pretty ok asio host, although it had some issues. Originally, 5 or so years ago pkv and I spent about 3+ days trying to reverse engineer the asio header for just this reason. Pretty confident that was the only thing missing because I vaguely remember making the same edit to build Juce. In short, good luck finding a source for that value that isn't the steinberg sdk, if you do, let me know, but don't worry I made that edit before so if that edit introduces a bug, that's been on me the entire time. |
This is the last build. https://github.com/wkpark/obs-asio/actions/runs/3017510916#artifacts |
Unless I'm mistaken you don't need the |
319d4e7
to
82e9808
Compare
* remove Steinberg's asio-sdk dependency * use the openasio-sdk to make it GPL compliant
(this is a squashed version of wkpark/obs-asio/workflows branch)
8bb65e3
to
8729406
Compare
@wkpark sorry, I ended up force-pushing to your branch instead of mine (I'll try to restore it later), if you'd like make sure you create a new workflows branch as a backup*. Edit: I restored your original branch on my end, Wizard and I will be going through it later (we'll do the squash which'll keep you as author). |
no problem. This PR closed by commit cef5c61 |
This is based on the recent obs-ndi work
.github/*
files are imported from the obs-plugintemplateyou can download this obs-asio prebuilt from the following link:
https://github.com/wkpark/obs-asio/actions/runs/2996020467#artifactshttps://github.com/wkpark/obs-asio/actions/runs/3017510916#artifactshttps://github.com/wkpark/obs-asio/actions/runs/3019152627#artifactshttps://github.com/wkpark/obs-asio/actions/runs/3019464346#artifacts