New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build failure using 7cee718ce6b21947954c6b12bec1e4c70092a9f2 #666
Comments
Interesting. Any chance you could run make like this: VERBOSE=1 make and send me the output? It should have a lua library on the link line and ideally this library should have these symbols. Which version of lua do you have installed? |
I'm having the same error.
|
@ville-h @Andersbakken @floli You can verify that lua doesn't contain Which is interesting as the readme states, it should be compatible with lua-5.1 and above.
Alternative, using
That's all I can add at the moment :-/. regards, |
My system has lua5.1 and 5.3 installed and it appears that the build has decided to use 5.1 specifically. Which indeed doesn't have the symbols as mentioned by cslux. lua.h and liblua.so or what it points to are from 5.3.
|
This hasn't fixed it for me:
These lua versions I have installed:
Naively, I've tried to set the version to 5.3
but no change. |
it's still broken. seems to try to -llua5.1 as previously. |
Can you try to remove the CmakeCAche.txt and the cmake files directory. And
|
I did all tests on a fresh checkout, so I doubt it's a caching issue. But nevertheless, I tried and it changed nothing :-( |
Can you try this please? # add required version string to find_package
# before
find_package(Lua)
# after
find_package(Lua 5.3) Thanks! |
That fixed it for me!
|
Basically, commit b6c9848 can be reverted, and instead add this required version string to find_package, unless someone has a FindLua.cmake installed which doesn't do a version check. If that is the case I would add the FindLua.cmake from a newer cmake version to rtags/cmake/. Can you do me a favor, and test, if the build fails with Thanks! regards, |
Sure, tried it with Lua 5.2 and it does fail. |
Thanks! Florian Lindner notifications@github.com writes:
|
Should be fixed now! Reopen this issue if you still get errors regarding lua. |
Hm. I think 5.2 is supposed to be okay. Maybe we should do a compile and link test thingy? I only have 5.2 and it worked for me. Maybe the symbol(s) arrived in some patch release of 5.2. |
builds for me with lua5.3 except for couple:
|
Interesting, I will dig around a bit, but I think the only reliable way to satisfy all is to search first for lua-5.3, if it hasn't been found, search for lua-5.2, if lua-5.2 has been found, run a CMake test case to ensure version 5.2 is compatible with selene. Pseudocode: find_package(Lua 5.3)
if NOT LUA_FOUND
find_package(Lua 5.2)
if LUA_FOUND
run test case
if test fail
disable lua
end
if LUA_COMPATIBLE
....
end Or we find out the minimum 5.2.PATCH version we need, unless the package manager has written the patch than we have no other choice to do it like described above. @ville-h Good! Those function haven't bin implemented yet, just the signature was added. regards, |
I digged a bit around in the lua source code, unfortunate lua-5.2.4 which is the last patch release in the 5.2 series does not contain |
Lets just keep 5.3 then. Anders On Thu, Apr 28, 2016 at 12:00 PM, Christian Schwarzgruber <
|
Closing this now, as fixed! |
Build fails right now with following using 7cee718 :
The text was updated successfully, but these errors were encountered: