Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build failure using 7cee718ce6b21947954c6b12bec1e4c70092a9f2 #666

Closed
ville-h opened this issue Apr 24, 2016 · 20 comments
Closed

build failure using 7cee718ce6b21947954c6b12bec1e4c70092a9f2 #666

ville-h opened this issue Apr 24, 2016 · 20 comments

Comments

@ville-h
Copy link

ville-h commented Apr 24, 2016

Build fails right now with following using 7cee718 :

git clone --recursive https://github.com/Andersbakken/rtags.git
cd rtags
mkdir build
cd build
cmake ..
make
/home/ville/src/rtags/src/AST.cpp: In static member function ‘static std::shared_ptr<AST> AST::create(const Source&, CXTranslationUnit)’:
/home/ville/src/rtags/src/AST.cpp:114:1: warning: no return statement in function returning non-void [-Wreturn-type]
/home/ville/src/rtags/src/AST.cpp: In member function ‘List<AST::Diagnostic> AST::diagnostics() const’:
/home/ville/src/rtags/src/AST.cpp:118:1: warning: no return statement in function returning non-void [-Wreturn-type]
/home/ville/src/rtags/src/AST.cpp: In member function ‘List<AST::SkippedRange> AST::skippedRanges() const’:
/home/ville/src/rtags/src/AST.cpp:122:1: warning: no return statement in function returning non-void [-Wreturn-type]
[ 83%] Linking CXX executable ../bin/rc
librtags.a(AST.cpp.o): In function `AST::create(Source const&, CXTranslationUnitImpl*)':
AST.cpp:(.text+0xe7b): undefined reference to `lua_absindex'
AST.cpp:(.text+0xe8e): undefined reference to `lua_rotate'
...
@Andersbakken
Copy link
Owner

Interesting. Any chance you could run make like this:

VERBOSE=1 make

and send me the output?

It should have a lua library on the link line and ideally this library should have these symbols.

Which version of lua do you have installed?

@floli
Copy link
Contributor

floli commented Apr 26, 2016

I'm having the same error. cmake . says

-- The following OPTIONAL packages have been found:

 * Lua
 * ZLIB
 * OpenSSL

-- The following REQUIRED packages have been found:

 * LibClang
 * Curses

VERBOSE=1 make gives:

[ 85%] Linking CXX static library librtags.a
cd /home/florian/software/rtags/src && /usr/bin/cmake -P CMakeFiles/rtags.dir/cmake_clean_target.cmake
cd /home/florian/software/rtags/src && /usr/bin/cmake -E cmake_link_script CMakeFiles/rtags.dir/link.txt --verbose=1
/usr/bin/ar qc librtags.a  CMakeFiles/rtags.dir/ClangIndexer.cpp.o CMakeFiles/rtags.dir/ClangThread.cpp.o CMakeFiles/rtags.dir/ClassHierarchyJob.cpp.o CMakeFiles/rtags.dir/CompilerManager.cpp.o CMakeFiles/rtags.dir/CompletionThread.cpp.o CMakeFiles/rtags.dir/DependenciesJob.cpp.o CMakeFiles/rtags.dir/FileManager.cpp.o CMakeFiles/rtags.dir/FindFileJob.cpp.o CMakeFiles/rtags.dir/FindSymbolsJob.cpp.o CMakeFiles/rtags.dir/FollowLocationJob.cpp.o CMakeFiles/rtags.dir/IncludeFileJob.cpp.o CMakeFiles/rtags.dir/IndexMessage.cpp.o CMakeFiles/rtags.dir/IndexerJob.cpp.o CMakeFiles/rtags.dir/JobScheduler.cpp.o CMakeFiles/rtags.dir/ListSymbolsJob.cpp.o CMakeFiles/rtags.dir/Location.cpp.o CMakeFiles/rtags.dir/Preprocessor.cpp.o CMakeFiles/rtags.dir/Project.cpp.o CMakeFiles/rtags.dir/QueryJob.cpp.o CMakeFiles/rtags.dir/QueryMessage.cpp.o CMakeFiles/rtags.dir/RClient.cpp.o CMakeFiles/rtags.dir/RTags.cpp.o CMakeFiles/rtags.dir/ReferencesJob.cpp.o CMakeFiles/rtags.dir/ScanThread.cpp.o CMakeFiles/rtags.dir/Server.cpp.o CMakeFiles/rtags.dir/Source.cpp.o CMakeFiles/rtags.dir/StatusJob.cpp.o CMakeFiles/rtags.dir/Symbol.cpp.o CMakeFiles/rtags.dir/SymbolInfoJob.cpp.o CMakeFiles/rtags.dir/rct/rct/AES256CBC.cpp.o CMakeFiles/rtags.dir/rct/rct/SHA256.cpp.o CMakeFiles/rtags.dir/rct/rct/Buffer.cpp.o CMakeFiles/rtags.dir/rct/rct/Config.cpp.o CMakeFiles/rtags.dir/rct/rct/Connection.cpp.o CMakeFiles/rtags.dir/rct/rct/CpuUsage.cpp.o CMakeFiles/rtags.dir/rct/rct/Date.cpp.o CMakeFiles/rtags.dir/rct/rct/EventLoop.cpp.o CMakeFiles/rtags.dir/rct/rct/FileSystemWatcher.cpp.o CMakeFiles/rtags.dir/rct/rct/Log.cpp.o CMakeFiles/rtags.dir/rct/rct/MemoryMonitor.cpp.o CMakeFiles/rtags.dir/rct/rct/Message.cpp.o CMakeFiles/rtags.dir/rct/rct/MessageQueue.cpp.o CMakeFiles/rtags.dir/rct/rct/Path.cpp.o CMakeFiles/rtags.dir/rct/rct/Plugin.cpp.o CMakeFiles/rtags.dir/rct/rct/Process.cpp.o CMakeFiles/rtags.dir/rct/rct/Rct.cpp.o CMakeFiles/rtags.dir/rct/rct/ReadWriteLock.cpp.o CMakeFiles/rtags.dir/rct/rct/Semaphore.cpp.o CMakeFiles/rtags.dir/rct/rct/SharedMemory.cpp.o CMakeFiles/rtags.dir/rct/rct/SocketClient.cpp.o CMakeFiles/rtags.dir/rct/rct/SocketServer.cpp.o CMakeFiles/rtags.dir/rct/rct/String.cpp.o CMakeFiles/rtags.dir/rct/rct/Thread.cpp.o CMakeFiles/rtags.dir/rct/rct/ThreadPool.cpp.o CMakeFiles/rtags.dir/rct/rct/Timer.cpp.o CMakeFiles/rtags.dir/rct/rct/Value.cpp.o CMakeFiles/rtags.dir/rct/cJSON/cJSON.c.o CMakeFiles/rtags.dir/rct/rct/FileSystemWatcher_inotify.cpp.o CMakeFiles/rtags.dir/AST.cpp.o
/usr/bin/ranlib librtags.a
make[2]: Leaving directory '/home/florian/software/rtags'
[ 85%] Built target rtags
make -f src/CMakeFiles/rc.dir/build.make src/CMakeFiles/rc.dir/depend
make[2]: Entering directory '/home/florian/software/rtags'
cd /home/florian/software/rtags && /usr/bin/cmake -E cmake_depends "Unix Makefiles" /home/florian/software/rtags /home/florian/software/rtags/src /home/florian/software/rtags /home/florian/software/rtags/src /home/florian/software/rtags/src/CMakeFiles/rc.dir/DependInfo.cmake --color=
Dependee "/home/florian/software/rtags/src/CMakeFiles/rc.dir/DependInfo.cmake" is newer than depender "/home/florian/software/rtags/src/CMakeFiles/rc.dir/depend.internal".
Dependee "/home/florian/software/rtags/src/CMakeFiles/CMakeDirectoryInformation.cmake" is newer than depender "/home/florian/software/rtags/src/CMakeFiles/rc.dir/depend.internal".
Scanning dependencies of target rc
make[2]: Leaving directory '/home/florian/software/rtags'
make -f src/CMakeFiles/rc.dir/build.make src/CMakeFiles/rc.dir/build
make[2]: Entering directory '/home/florian/software/rtags'
[ 87%] Building CXX object src/CMakeFiles/rc.dir/rc.cpp.o
cd /home/florian/software/rtags/src && /usr/bin/c++   -DCLANG_LIBDIR=/usr/lib -DOS_Linux -DRCT_HAVE_OPENSSL -DRCT_HAVE_ZLIB -DRTAGS_HAS_LUA -I/home/florian/software/rtags/src -I/home/florian/software/rtags/src/rct -I/home/florian/software/rtags/src/include -I/home/florian/software/rtags/src/selene/include  -I/usr/include -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Wall -Wextra -Wpointer-arith -Wnon-virtual-dtor -std=c++11 -Wall -Wextra -Wpointer-arith -Wnon-virtual-dtor -std=c++11 -Wstrict-aliasing=2 -Wcast-qual -fPIC -fstack-protector-all -Wstack-protector -O3 -DNDEBUG   -o CMakeFiles/rc.dir/rc.cpp.o -c /home/florian/software/rtags/src/rc.cpp
[ 88%] Linking CXX executable ../bin/rc
cd /home/florian/software/rtags/src && /usr/bin/cmake -E cmake_link_script CMakeFiles/rc.dir/link.txt --verbose=1
/usr/bin/c++    -I/usr/include -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Wall -Wextra -Wpointer-arith -Wnon-virtual-dtor -std=c++11 -Wall -Wextra -Wpointer-arith -Wnon-virtual-dtor -std=c++11 -Wstrict-aliasing=2 -Wcast-qual -fPIC -fstack-protector-all -Wstack-protector -O3 -DNDEBUG   CMakeFiles/rc.dir/rc.cpp.o  -o ../bin/rc -rdynamic librtags.a -Wl,--start-group -lclang -Wl,--end-group -lstdc++ -lcurses -lform -lpthread -lz -lcrypto -ldl -lrt -llua5.2 -lm -Wl,-rpath,::::::::::::::: 
librtags.a(AST.cpp.o): In function `AST::create(Source const&, String const&, CXTranslationUnitImpl*)':
AST.cpp:(.text+0x2786): undefined reference to `lua_rotate'
librtags.a(AST.cpp.o): In function `sel::Selector::_evaluate_function_call(int) const':
AST.cpp:(.text._ZNK3sel8Selector23_evaluate_function_callEi[_ZNK3sel8Selector23_evaluate_function_callEi]+0x113): undefined reference to `lua_rotate'
librtags.a(AST.cpp.o): In function `sel::Selector::_traverse() const':
AST.cpp:(.text._ZNK3sel8Selector9_traverseEv[_ZNK3sel8Selector9_traverseEv]+0x86): undefined reference to `lua_rotate'
librtags.a(AST.cpp.o): In function `sel::Selector::~Selector()':
AST.cpp:(.text._ZN3sel8SelectorD2Ev[_ZN3sel8SelectorD5Ev]+0x94): undefined reference to `lua_rotate'
librtags.a(AST.cpp.o): In function `sel::Fun<1, AST::Cursor>::Apply(lua_State*)':
AST.cpp:(.text._ZN3sel3FunILi1EN3AST6CursorEJEE5ApplyEP9lua_State[_ZN3sel3FunILi1EN3AST6CursorEJEE5ApplyEP9lua_State]+0x149): undefined reference to `lua_rotate'
librtags.a(AST.cpp.o):AST.cpp:(.text._ZN3sel8ClassFunILi1EKN3AST14SourceLocationEiJEE4_getEP9lua_State[_ZN3sel8ClassFunILi1EKN3AST14SourceLocationEiJEE4_getEP9lua_State]+0x3b): more undefined references to `lua_rotate' follow
collect2: error: ld returned 1 exit status
src/CMakeFiles/rc.dir/build.make:102: recipe for target 'bin/rc' failed
make[2]: *** [bin/rc] Error 1
make[2]: Leaving directory '/home/florian/software/rtags'
CMakeFiles/Makefile2:195: recipe for target 'src/CMakeFiles/rc.dir/all' failed
make[1]: *** [src/CMakeFiles/rc.dir/all] Error 2
make[1]: Leaving directory '/home/florian/software/rtags'
Makefile:127: recipe for target 'all' failed
make: *** [all] Error 2

@casch-at
Copy link
Collaborator

@ville-h @Andersbakken @floli
After a quick investigation I found out that those missing functions were added in lua-5.3. On my system (Fedora 23 with lua-5.3), compiling rtags works.

You can verify that lua doesn't contain lua_rotate and lua_absindex in /usr/include/lua.h. https://www.lua.org/source/5.2/lua.h.html

Which is interesting as the readme states, it should be compatible with lua-5.1 and above.

grep -E "lua_(rotate|absindex)" /usr/include/lua.h

LUA_API int   (lua_absindex) (lua_State *L, int idx);
LUA_API void  (lua_rotate) (lua_State *L, int idx, int n);
#define lua_insert(L,idx)       lua_rotate(L, (idx), 1)
#define lua_remove(L,idx)       (lua_rotate(L, (idx), -1), lua_pop(L, 1))

Alternative, using objdump on the lua library:

objdump -CT /usr/lib64/liblua-5.3.so | grep -E "lua_(rotate|absindex)"

0000000000008510 g    DF .text  00000000000000f7  Base        lua_rotate
0000000000008470 g    DF .text  0000000000000023  Base        lua_absindex

That's all I can add at the moment :-/.

regards,
Christian

@ville-h
Copy link
Author

ville-h commented Apr 27, 2016

My system has lua5.1 and 5.3 installed and it appears that the build has decided to use 5.1 specifically. Which indeed doesn't have the symbols as mentioned by cslux. lua.h and liblua.so or what it points to are from 5.3.

[ 83%] Linking CXX executable ../bin/rc
cd /home/ville/tmp/rtags/build/src && /usr/bin/cmake -E cmake_link_script CMakeFiles/rc.dir/link.txt --verbose=1
/usr/bin/c++    -I/usr/include -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Wall -Wextra -Wpointer-arith -Wnon-virtual-dtor -std=c++11 -Wall -Wextra -Wpointer-arith -Wnon-virtual-dtor -std=c++11 -Wstrict-aliasing=2 -Wcast-qual -fPIC -fstack-protector-all -Wstack-protector -O3 -DNDEBUG   CMakeFiles/rc.dir/rc.cpp.o  -o ../bin/rc -rdynamic librtags.a -Wl,--start-group -lclang -Wl,--end-group -lstdc++ -lcurses -lform -lpthread -lz -lcrypto -ldl -lrt -llua5.1 -lm -Wl,-rpath,::::::::::::::: 
librtags.a(AST.cpp.o): In function `AST::evaluate(String const&)':
AST.cpp:(.text+0x434): undefined reference to `lua_pcallk'
...

Andersbakken added a commit that referenced this issue Apr 27, 2016
@floli
Copy link
Contributor

floli commented Apr 27, 2016

This hasn't fixed it for me:

[ 88%] Linking CXX executable ../bin/rc
cd /home/florian/software/rtags/src && /usr/bin/cmake -E cmake_link_script CMakeFiles/rc.dir/link.txt --verbose=1
/usr/bin/c++    -I/usr/include -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Wall -Wextra -Wpointer-arith -Wnon-virtual-dtor -std=c++11 -Wall -Wextra -Wpointer-arith -Wnon-virtual-dtor -std=c++11 -Wstrict-aliasing=2 -Wcast-qual -fPIC -fstack-protector-all -Wstack-protector -O3 -DNDEBUG   CMakeFiles/rc.dir/rc.cpp.o  -o ../bin/rc -rdynamic librtags.a -Wl,--start-group -lclang -Wl,--end-group -lstdc++ -lcurses -lform -lpthread -lz -lcrypto -ldl -lrt -llua5.2 -lm -Wl,-rpath,::::::::::::::: 
librtags.a(AST.cpp.o): In function `AST::create(Source const&, String const&, CXTranslationUnitImpl*)':
AST.cpp:(.text+0x2786): undefined reference to `lua_rotate'
librtags.a(AST.cpp.o): In function `sel::Selector::_evaluate_function_call(int) const':
AST.cpp:(.text._ZNK3sel8Selector23_evaluate_function_callEi[_ZNK3sel8Selector23_evaluate_function_callEi]+0x113): undefined reference to `lua_rotate'
librtags.a(AST.cpp.o): In function `sel::Selector::_traverse() const':
AST.cpp:(.text._ZNK3sel8Selector9_traverseEv[_ZNK3sel8Selector9_traverseEv]+0x86): undefined reference to `lua_rotate'
librtags.a(AST.cpp.o): In function `sel::Selector::~Selector()':
AST.cpp:(.text._ZN3sel8SelectorD2Ev[_ZN3sel8SelectorD5Ev]+0x94): undefined reference to `lua_rotate'
librtags.a(AST.cpp.o): In function `sel::Fun<1, AST::Cursor>::Apply(lua_State*)':
AST.cpp:(.text._ZN3sel3FunILi1EN3AST6CursorEJEE5ApplyEP9lua_State[_ZN3sel3FunILi1EN3AST6CursorEJEE5ApplyEP9lua_State]+0x149): undefined reference to `lua_rotate'
librtags.a(AST.cpp.o):AST.cpp:(.text._ZN3sel8ClassFunILi1EKN3AST14SourceLocationEiJEE4_getEP9lua_State[_ZN3sel8ClassFunILi1EKN3AST14SourceLocationEiJEE4_getEP9lua_State]+0x3b): more undefined references to `lua_rotate' follow
collect2: Fehler: ld gab 1 als Ende-Status zurück
src/CMakeFiles/rc.dir/build.make:102: die Regel für Ziel „bin/rc“ scheiterte
make[2]: *** [bin/rc] Fehler 1
make[2]: Verzeichnis „/home/florian/software/rtags“ wird verlassen
CMakeFiles/Makefile2:195: die Regel für Ziel „src/CMakeFiles/rc.dir/all“ scheiterte
make[1]: *** [src/CMakeFiles/rc.dir/all] Fehler 2
make[1]: Verzeichnis „/home/florian/software/rtags“ wird verlassen
Makefile:127: die Regel für Ziel „all“ scheiterte
make: *** [all] Fehler 2
VERBOSE=1 make  202,72s user 6,07s system 99% cpu 3:29,55 total

These lua versions I have installed:

local/lua 5.3.2-1
    Powerful lightweight programming language designed for extending applications
local/lua51 5.1.5-4
    Powerful lightweight programming language designed for extending applications
local/lua52 5.2.4-1
    Powerful lightweight programming language designed for extending applications

Naively, I've tried to set the version to 5.3

diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt
index 161fa5e..ca0b1d5 100644
--- a/src/CMakeLists.txt
+++ b/src/CMakeLists.txt
@@ -41,7 +41,7 @@ endif ()

 find_package(Lua)
 If (LUA_FOUND)
-    string(COMPARE LESS "${LUA_VERSION_MAJOR}.${LUA_VERSION_MINOR}" "5.2" LUA_TOO_OLD)
+    string(COMPARE LESS "${LUA_VERSION_MAJOR}.${LUA_VERSION_MINOR}" "5.3" LUA_TOO_OLD)
     if (${LUA_TOO_OLD})
         set(LUA_FOUND 0)
     else ()

but no change.

@ville-h
Copy link
Author

ville-h commented Apr 27, 2016

it's still broken. seems to try to -llua5.1 as previously.

@Andersbakken
Copy link
Owner

Can you try to remove the CmakeCAche.txt and the cmake files directory. And
retry?
On Wed, Apr 27, 2016 at 7:42 AM ville-h notifications@github.com wrote:

it's still broken. seems to try to -llua5.1 as previously.


You are receiving this because you were mentioned.

Reply to this email directly or view it on GitHub
#666 (comment)

@floli
Copy link
Contributor

floli commented Apr 27, 2016

I did all tests on a fresh checkout, so I doubt it's a caching issue. But nevertheless, I tried and it changed nothing :-(

@casch-at
Copy link
Collaborator

@floli

Can you try this please?

# add  required version string to find_package
# before
find_package(Lua)
# after
find_package(Lua 5.3)

Thanks!

@floli
Copy link
Contributor

floli commented Apr 27, 2016

That fixed it for me!

diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt
index 161fa5e..049c7cd 100644
--- a/src/CMakeLists.txt
+++ b/src/CMakeLists.txt
@@ -39,7 +39,7 @@ if (EXISTS ${CLANG_COMPILATION_INCLUDE})
     add_definitions(-DHAVE_CXCOMPILATIONDATABASE)
 endif ()

-find_package(Lua)
+find_package(Lua 5.3)
 If (LUA_FOUND)
     string(COMPARE LESS "${LUA_VERSION_MAJOR}.${LUA_VERSION_MINOR}" "5.2" LUA_TOO_OLD)
     if (${LUA_TOO_OLD})

@casch-at
Copy link
Collaborator

Basically, commit b6c9848 can be reverted, and instead add this required version string to find_package, unless someone has a FindLua.cmake installed which doesn't do a version check. If that is the case I would add the FindLua.cmake from a newer cmake version to rtags/cmake/.

@floli

Can you do me a favor, and test, if the build fails with find_package(Lua 5.2)? As far as I know, at least lua-5.3 is required so it should fail.

Thanks!

regards,
Christian

@floli
Copy link
Contributor

floli commented Apr 27, 2016

Sure, tried it with Lua 5.2 and it does fail.

@casch-at
Copy link
Collaborator

Thanks!

Florian Lindner notifications@github.com writes:

Sure, tried it with Lua 5.2 and it does fail.


You are receiving this because you commented.
Reply to this email directly or view it on GitHub

casch-at added a commit that referenced this issue Apr 27, 2016
@casch-at
Copy link
Collaborator

Should be fixed now! Reopen this issue if you still get errors regarding lua.

@Andersbakken
Copy link
Owner

Hm. I think 5.2 is supposed to be okay. Maybe we should do a compile and link test thingy? I only have 5.2 and it worked for me. Maybe the symbol(s) arrived in some patch release of 5.2.

@Andersbakken Andersbakken reopened this Apr 28, 2016
@ville-h
Copy link
Author

ville-h commented Apr 28, 2016

builds for me with lua5.3 except for couple:

/home/ville/tmp/rtags/src/AST.cpp: In member function ‘List<AST::Diagnostic> AST::diagnostics() const’:
/home/ville/tmp/rtags/src/AST.cpp:137:1: warning: no return statement in function returning non-void [-Wreturn-type]
 }
 ^
/home/ville/tmp/rtags/src/AST.cpp: In member function ‘List<AST::SkippedRange> AST::skippedRanges() const’:
/home/ville/tmp/rtags/src/AST.cpp:141:1: warning: no return statement in function returning non-void [-Wreturn-type]
 }

@casch-at
Copy link
Collaborator

@Andersbakken

Interesting, I will dig around a bit, but I think the only reliable way to satisfy all is to search first for lua-5.3, if it hasn't been found, search for lua-5.2, if lua-5.2 has been found, run a CMake test case to ensure version 5.2 is compatible with selene.

Pseudocode:

find_package(Lua 5.3)
if NOT LUA_FOUND
   find_package(Lua 5.2)
      if LUA_FOUND
         run test case
           if test fail
              disable lua
end

if LUA_COMPATIBLE
  ....
end

Or we find out the minimum 5.2.PATCH version we need, unless the package manager has written the patch than we have no other choice to do it like described above.

@ville-h Good! Those function haven't bin implemented yet, just the signature was added.

regards,
Christian

@casch-at
Copy link
Collaborator

I digged a bit around in the lua source code, unfortunate lua-5.2.4 which is the last patch release in the 5.2 series does not contain lua_rotate, lua_rotate was added in lua-5.3.0. So I guess someone has probably patched the lua on iOS X.

@Andersbakken
Copy link
Owner

Lets just keep 5.3 then.

Anders

On Thu, Apr 28, 2016 at 12:00 PM, Christian Schwarzgruber <
notifications@github.com> wrote:

I digged a bit around in the lua source code, unfortunate lua-5.2.4 which
is the last patch release in the 5.2 series does not contain lua_rotate,
lua_rotate was added in lua-5.3.0. So I guess someone has probably
patched the lua on iOS X.


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#666 (comment)

@casch-at
Copy link
Collaborator

Closing this now, as fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants