Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build issue on OSX with nix package-manager #891

Closed
periklis opened this issue Jan 17, 2017 · 3 comments
Closed

Build issue on OSX with nix package-manager #891

periklis opened this issue Jan 17, 2017 · 3 comments

Comments

@periklis
Copy link

Since the last release of rtags on nix was 2.3 and that's a long time ago, i tried to update it to 2.8 in order to benefit from the ---extra-compilers option. However, i stumbled upon an issue with the preprossecor ifdefs in rdm.cpp around the FileManagerWatch. Following error:

[ 86%] Building CXX object src/CMakeFiles/rdm.dir/rdm.cpp.o
In file included from /private/var/folders/tv/h06nsg4s31b9lcd0_wl1rcjh0000gn/T/nix-build-rtags-2.8.drv-0/rtags/src/rdm.cpp:32:
/private/var/folders/tv/h06nsg4s31b9lcd0_wl1rcjh0000gn/T/nix-build-rtags-2.8.drv-0/rtags/src/RTags.h:978:5: warning: default label in switch which covers all enumeration values [-Wc
overed-switch-default]                                                                                                                                                              
    default:
    ^
/private/var/folders/tv/h06nsg4s31b9lcd0_wl1rcjh0000gn/T/nix-build-rtags-2.8.drv-0/rtags/src/rdm.cpp:318:11: error: use of undeclared identifier 'FileManagerWatch'; did you mean 'No
FileManagerWatch'?                                                                                                                                                                  
        { FileManagerWatch, "filemanager-watch", 'M', CommandLineParser::NoValue, "Use a file system watcher for filemanager." },
          ^~~~~~~~~~~~~~~~
          NoFileManagerWatch
/private/var/folders/tv/h06nsg4s31b9lcd0_wl1rcjh0000gn/T/nix-build-rtags-2.8.drv-0/rtags/src/rdm.cpp:184:5: note: 'NoFileManagerWatch' declared here
    NoFileManagerWatch,
    ^
/private/var/folders/tv/h06nsg4s31b9lcd0_wl1rcjh0000gn/T/nix-build-rtags-2.8.drv-0/rtags/src/rdm.cpp:585:14: error: use of undeclared identifier 'FileManagerWatch'; did you mean 'No
FileManagerWatch'?                                                                                                                                                                  
        case FileManagerWatch: {
             ^~~~~~~~~~~~~~~~
             NoFileManagerWatch
/private/var/folders/tv/h06nsg4s31b9lcd0_wl1rcjh0000gn/T/nix-build-rtags-2.8.drv-0/rtags/src/rdm.cpp:184:5: note: 'NoFileManagerWatch' declared here
    NoFileManagerWatch,
    ^
1 warning and 2 errors generated.

I think there is an interaction issue with lines L39, which enables FILEMANAGER_OPT_IN and L181, which does not enable FileManagerWatch in OptionEnum. Why is there only a check for OS_FreeBSD on latter?

Btw, with CoreServices in my buildInputs cmake tells me that kqueue is found.

RTags build inputs

@Andersbakken
Copy link
Owner

Andersbakken commented Jan 21, 2017 via email

@periklis
Copy link
Author

@Andersbakken Thx, could you make a release for this?

@periklis
Copy link
Author

periklis commented Feb 7, 2017

It works now, i'll close the issue.

@periklis periklis closed this as completed Feb 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants