Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

Identifying the currently selected app #95

Closed
willlunniss opened this issue Jul 6, 2012 · 12 comments
Closed

Identifying the currently selected app #95

willlunniss opened this issue Jul 6, 2012 · 12 comments
Milestone

Comments

@willlunniss
Copy link
Contributor

At the moment it is no longer possible to work out which app you are viewing stats for. Previously you could see the app's icon in the top left corner.

My ideal solution would be to return the app's icon to the top left and or stick the package name as the subtitle in the action bar and in the case where there is a subtitle at the moment, promote that to be the main title. I would also like to see the package name in a slightly grey colour as it generally used on a dark actionbar.

I'm more than happy to do this, however I seem to remember a brief talk about it (but cannot remember which issue it was in), so wanted to bring it up before going ahead.

@AndyScherzinger
Copy link
Member

Hi @willlunniss the code still has the path to the apps icon. I am not sure we want to put that one in the action bar though.

Package name in the subtitle is something I was planing to do anyways to be able to see which app's stats I am looking at (so it would be kinda like the ICS mail app) + Putting the actual subtitle in the main title. How would you change the subtitle color? Not sure if this can be changed easily. One would have to check the theming to see if this can be overridden. Probably you'll find something over here:
http://actionbarsherlock.com/theming.html

Would you mind doing it since I won't find the time for it before mid/end next week?

@willlunniss
Copy link
Contributor Author

Subtitle + style change is pretty simple, I'll do it tonight after work. If you ever need to lookup style stuff, just look in values/abs__styles.xml for ideas of what is available.

Re: Icon, I think I'm for it, but i'll leave it for now until others give their view.

@AndyScherzinger
Copy link
Member

Thanks for the hint.

Re: Icon, I am fine either way. Anyone else? Andlytics icon or app icon?

App icon would be consistent with actual and past releases.

@schoentoon
Copy link
Contributor

I actually have something else to add here. Andlytics will always show the application name from the apk, not from the name visible in the Play Store, which can be kinda annoying when you have like a paid and a free version of a specific app but the application name in the apk is exactly the same. If you'll show the app icon in the top of the screen I suggest you show the name of it visible in the play store as well.

@AndyScherzinger
Copy link
Member

That kind of changes the requirement / suggestion of this ticket. @willlunniss wants to show the package name in the action bar which has to be different for free/pro versions since it is the "key" in the market.

As for the app name shown on the "main view" I agree that it would be nicer to see/display the name configured in the market.

Off topic: Out of curiosity: Why would you use the same name for free and pro version? This leads to the same label when added to the screen and in the app drawer. We should support this anyways but it sounds kind of legacy since with in-app billing etc. I build exactly one app with pro checks via in-app billing API. Just my 2 cents :)

@fda77
Copy link
Contributor

fda77 commented Jul 6, 2012

+ for app icon, not Andlytics icon

@AndyScherzinger
Copy link
Member

+1 for app icon, not Andlytics icon

@willlunniss
Copy link
Contributor Author

#98

What do you think about the package name as the subtitle? Would it be better to use the app's name (either apk/google play varient)? Could we even leave it as a display option for the user.

If we do go for packag ename, then it might be nice to make the package name more prominant on the main app list, rather than hidden below the expanded ratings.

@schoentoon
Copy link
Contributor

I personally think showing the name from the Google Play Store would be best. But hey, making it a setting can work for everyone.

@willlunniss
Copy link
Contributor Author

Ok so the proposal would be to fetch google play name and then add an option to

Display the app name as either:
*APK name
*Google Play name

Then change subtitle to be the app name rather than the package name or have an option.

@vdesmet93
Copy link

+1 for Play Store name. The Play Store name is easy to understand. In addition, the Play Store name is unique, so you won't get issues with duplicate names.

The packagename is basically just an ID.

@willlunniss
Copy link
Contributor Author

Ok, I'll have a look at how to get the Google Play name at the weekend, if anyone has time to work it out that would be great as I'm very busy at the moment.

Sent via Hubroid

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants