Fixed onToggle to return false upon keyboard close #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously it always returned true regardless of state.
|
Just tested, this causes jumping when the keyboard closes on iOS. |
|
@Andr3wHur5t What do you mean? It seems to work normally for me except now toggleState is returning a different value. |
|
I'm looking into a fix, probably need to check if the height is 0. |
|
@dvassilev this fix seems to be causing an issue with the hide animation. On master its smooth, on this branch it jumps down after the keyboard finishes its transition. |
|
@Andr3wHur5t Odd, it remains a smooth transition for me. |
|
@dvassilev my bad, seems the simulator was sending multiple events. Restarting the simulator fixed it. Looks good 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it always returned true regardless of state.