Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash, particles null #12

Closed
modulovalue opened this issue Jan 12, 2019 · 1 comment
Closed

Crash, particles null #12

modulovalue opened this issue Jan 12, 2019 · 1 comment

Comments

@modulovalue
Copy link 

The getter 'length' was called on null.
flutter: Receiver: null
flutter: Tried calling: length
flutter: 
flutter: When the exception was thrown, this was the stack:
flutter: #0      Object.noSuchMethod (dart:core/runtime/libobject_patch.dart:50:5)
flutter: #1      ParticleBehaviour.onOptionsUpdate (package:animated_background/particles.dart:372:19)
flutter: #2      RandomParticleBehaviour.onOptionsUpdate (package:animated_background/particles.dart:458:11)
flutter: #3      ParticleBehaviour.initFrom (package:animated_background/particles.dart:291:7)
flutter: #4      RandomParticleBehaviour.initFrom (package:animated_background/particles.dart:409:11)
flutter: #5      RenderAnimatedBackground.behaviour= (package:animated_background/animated_background.dart:187:16)
flutter: #6      AnimatedBackground.updateRenderObject (package:animated_background/animated_background.dart:44:19)
flutter: #7      RenderObjectElement.update (package:flutter/src/widgets/framework.dart:4494:12)
flutter: #8      _AnimatedBackgroundElement.update (package:animated_background/animated_background.dart:106:11)
flutter: #9      Element.updateChild (package:flutter/src/widgets/framework.dart:2742:15)
flutter: #10     SingleChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:4867:14)
flutter: #11     Element.updateChild (package:flutter/src/widgets/framework.dart:2742:15)
flutter: #12     ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3732:16)
flutter: #13     Element.rebuild (package:flutter/src/widgets/framework.dart:3547:5)
flutter: #14     StatelessElement.update (package:flutter/src/widgets/framework.dart:3781:5)
flutter: #15     Element.updateChild (package:flutter/src/widgets/framework.dart:2742:15)
flutter: #16     SingleChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:4867:14)
flutter: #17     Element.updateChild (package:flutter/src/widgets/framework.dart:2742:15)
flutter: #18     ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3732:16)
flutter: #19     Element.rebuild (package:flutter/src/widgets/framework.dart:3547:5)
flutter: #20     StatelessElement.update (package:flutter/src/widgets/framework.dart:3781:5)
flutter: #21     Element.updateChild (package:flutter/src/widgets/framework.dart:2742:15)
flutter: #22     ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3732:16)
flutter: #23     Element.rebuild (package:flutter/src/widgets/framework.dart:3547:5)
flutter: #24     StatelessElement.update (package:flutter/src/widgets/framework.dart:3781:5)
flutter: #25     Element.updateChild (package:flutter/src/widgets/framework.dart:2742:15)
flutter: #26     ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3732:16)
flutter: #27     Element.rebuild (package:flutter/src/widgets/framework.dart:3547:5)
flutter: #28     StatelessElement.update (package:flutter/src/widgets/framework.dart:3781:5)
flutter: #29     Element.updateChild (package:flutter/src/widgets/framework.dart:2742:15)
flutter: #30     ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3732:16)
flutter: #31     Element.rebuild (package:flutter/src/widgets/framework.dart:3547:5)
flutter: #32     StatelessElement.update (package:flutter/src/widgets/framework.dart:3781:5)
flutter: #33     Element.updateChild (package:flutter/src/widgets/framework.dart:2742:15)
flutter: #34     ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3732:16)
flutter: #35     Element.rebuild (package:flutter/src/widgets/framework.dart:3547:5)
flutter: #36     StatefulElement.update (package:flutter/src/widgets/framework.dart:3878:5)
flutter: #37     Element.updateChild (package:flutter/src/widgets/framework.dart:2742:15)
flutter: #38     ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3732:16)
flutter: #39     Element.rebuild (package:flutter/src/widgets/framework.dart:3547:5)
flutter: #40     StatefulElement.update (package:flutter/src/widgets/framework.dart:3878:5)
flutter: #41     Element.updateChild (package:flutter/src/widgets/framework.dart:2742:15)
flutter: #42     ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3732:16)
flutter: #43     Element.rebuild (package:flutter/src/widgets/framework.dart:3547:5)
flutter: #44     StatelessElement.update (package:flutter/src/widgets/framework.dart:3781:5)
flutter: #45     Element.updateChild (package:flutter/src/widgets/framework.dart:2742:15)
flutter: #46     ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3732:16)
flutter: #47     Element.rebuild (package:flutter/src/widgets/framework.dart:3547:5)
flutter: #48     StatelessElement.update (package:flutter/src/widgets/framework.dart:3781:5)
flutter: #49     Element.updateChild (package:flutter/src/widgets/framework.dart:2742:15)
flutter: #50     ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3732:16)
flutter: #51     Element.rebuild (package:flutter/src/widgets/framework.dart:3547:5)
flutter: #52     StatefulElement.update (package:flutter/src/widgets/framework.dart:3878:5)
flutter: #53     Element.updateChild (package:flutter/src/widgets/framework.dart:2742:15)
flutter: #54     ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3732:16)
flutter: #55     Element.rebuild (package:flutter/src/widgets/framework.dart:3547:5)
flutter: #56     StatefulElement.update (package:flutter/src/widgets/framework.dart:3878:5)
flutter: #57     Element.updateChild (package:flutter/src/widgets/framework.dart:2742:15)
flutter: #58     SingleChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:4867:14)
flutter: #59     Element.updateChild (package:flutter/src/widgets/framework.dart:2742:15)
flutter: #60     ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3732:16)
flutter: #61     Element.rebuild (package:flutter/src/widgets/framework.dart:3547:5)
flutter: #62     StatelessElement.update (package:flutter/src/widgets/framework.dart:3781:5)
flutter: #63     Element.updateChild (package:flutter/src/widgets/framework.dart:2742:15)
flutter: #64     RenderObjectElement.updateChildren (package:flutter/src/widgets/framework.dart:4585:32)
flutter: #65     MultiChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:4975:17)
flutter: #66     Element.updateChild (package:flutter/src/widgets/framework.dart:2742:15)
flutter: #67     ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3732:16)
flutter: #68     Element.rebuild (package:flutter/src/widgets/framework.dart:3547:5)
flutter: #69     StatefulElement.update (package:flutter/src/widgets/framework.dart:3878:5)
flutter: #70     Element.updateChild (package:flutter/src/widgets/framework.dart:2742:15)
flutter: #71     SingleChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:4867:14)
flutter: #72     Element.updateChild (package:flutter/src/widgets/framework.dart:2742:15)
flutter: #73     ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3732:16)
flutter: #74     Element.rebuild (package:flutter/src/widgets/framework.dart:3547:5)
flutter: #75     StatelessElement.update (package:flutter/src/widgets/framework.dart:3781:5)
flutter: #76     Element.updateChild (package:flutter/src/widgets/framework.dart:2742:15)
flutter: #77     ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3732:16)
flutter: #78     Element.rebuild (package:flutter/src/widgets/framework.dart:3547:5)
flutter: #79     StatelessElement.update (package:flutter/src/widgets/framework.dart:3781:5)
flutter: #80     Element.updateChild (package:flutter/src/widgets/framework.dart:2742:15)
flutter: #81     SingleChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:4867:14)
flutter: #82     Element.updateChild (package:flutter/src/widgets/framework.dart:2742:15)
flutter: #83     RenderObjectElement.updateChildren (package:flutter/src/widgets/framework.dart:4585:32)
flutter: #84     MultiChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:4975:17)
flutter: #85     Element.updateChild (package:flutter/src/widgets/framework.dart:2742:15)
flutter: #86     ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3732:16)
flutter: #87     Element.rebuild (package:flutter/src/widgets/framework.dart:3547:5)
flutter: #88     ProxyElement.update (package:flutter/src/widgets/framework.dart:3990:5)
flutter: #89     Element.updateChild (package:flutter/src/widgets/framework.dart:2742:15)
flutter: #90     RenderObjectElement.updateChildren (package:flutter/src/widgets/framework.dart:4585:32)
flutter: #91     MultiChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:4975:17)
flutter: #92     Element.updateChild (package:flutter/src/widgets/framework.dart:2742:15)
flutter: #93     _LayoutBuilderElement._layout.<anonymous closure> (package:flutter/src/widgets/layout_builder.dart:118:18)
flutter: #94     BuildOwner.buildScope (package:flutter/src/widgets/framework.dart:2266:19)
flutter: #95     _LayoutBuilderElement._layout (package:flutter/src/widgets/layout_builder.dart:107:11)
flutter: #96     RenderObject.invokeLayoutCallback.<anonymous closure> (package:flutter/src/rendering/object.dart:1730:58)
flutter: #97     PipelineOwner._enableMutationsToDirtySubtrees (package:flutter/src/rendering/object.dart:799:15)
flutter: #98     RenderObject.invokeLayoutCallback (package:flutter/src/rendering/object.dart:1730:13)
flutter: #99     _RenderLayoutBuilder.performLayout (package:flutter/src/widgets/layout_builder.dart:205:5)
flutter: #100    RenderObject.layout (package:flutter/src/rendering/object.dart:1634:7)
flutter: #101    MultiChildLayoutDelegate.layoutChild (package:flutter/src/rendering/custom_layout.dart:142:11)
flutter: #102    _ScaffoldLayout.performLayout (package:flutter/src/material/scaffold.dart:340:7)
flutter: #103    MultiChildLayoutDelegate._callPerformLayout (package:flutter/src/rendering/custom_layout.dart:212:7)
flutter: #104    RenderCustomMultiChildLayoutBox.performLayout (package:flutter/src/rendering/custom_layout.dart:356:14)
flutter: #105    RenderObject.layout (package:flutter/src/rendering/object.dart:1634:7)
flutter: #106    _RenderProxyBox&RenderBox&RenderObjectWithChildMixin&RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:104:13)
flutter: #107    RenderObject.layout (package:flutter/src/rendering/object.dart:1634:7)
flutter: #108    _RenderProxyBox&RenderBox&RenderObjectWithChildMixin&RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:104:13)
flutter: #109    _RenderCustomClip.performLayout (package:flutter/src/rendering/proxy_box.dart:1203:11)
flutter: #110    RenderObject.layout (package:flutter/src/rendering/object.dart:1634:7)
flutter: #111    _RenderProxyBox&RenderBox&RenderObjectWithChildMixin&RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:104:13)
flutter: #112    RenderObject.layout (package:flutter/src/rendering/object.dart:1634:7)
flutter: #113    RenderStack.performLayout (package:flutter/src/rendering/stack.dart:510:15)
flutter: #114    RenderObject.layout (package:flutter/src/rendering/object.dart:1634:7)
flutter: #115    MultiChildLayoutDelegate.layoutChild (package:flutter/src/rendering/custom_layout.dart:142:11)
flutter: #116    _ScaffoldLayout.performLayout (package:flutter/src/material/scaffold.dart:340:7)
flutter: #117    MultiChildLayoutDelegate._callPerformLayout (package:flutter/src/rendering/custom_layout.dart:212:7)
flutter: #118    RenderCustomMultiChildLayoutBox.performLayout (package:flutter/src/rendering/custom_layout.dart:356:14)
flutter: #119    RenderObject._layoutWithoutResize (package:flutter/src/rendering/object.dart:1509:7)
flutter: #120    PipelineOwner.flushLayout (package:flutter/src/rendering/object.dart:768:18)
flutter: #121

A temporary fix (probably not the best one) for RandomParticleBehaviour is


class FixedRandomParticleBehaviour extends RandomParticleBehaviour {
    FixedRandomParticleBehaviour({@required ParticleOptions options, Paint paint}) : super(options: options, paint: paint);
    @override
    void onOptionsUpdate(ParticleOptions oldOptions) {
        if (particles == null) {
            return;
        } else {
            super.onOptionsUpdate(oldOptions);
        }
    }
}

Thanks!
@AndreBaltazar8
Copy link
Owner

I will take a look. Thank you.

AndreBaltazar8 added a commit that referenced this issue Jan 12, 2019
@AndreBaltazar8
Fix particles options update crash when particles variable is null
130169e 
Resolves: #12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AndreBaltazar8 @modulovalue