Test volumes #27
Merged
Test volumes #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 24, 2018 21:05
With the new version of flake8 a piece of the code was raising an error. With the fix the string produces is the same, but it's less ambivalent, and flake8 like it.
Which kind of proves that we are actually working with Docker-Compose. Also, there's no printing in the tests.
1 similar comment
|
Oh man, please keep doing this, it's so much easier to review than a single PR with lots of commits! I really wish everybody did this :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #26
@AndreLouisCaron I hope this "continuous delivery" style of PRs is not bugging you much. If it is, I can just keep adding stuff to a single pull request. But if we keep separate ones, we can have a more detailed talk (if it's necessary) about each particular change.