Add proto='tcp' kwarg to port_for

[vicyap]

I have a use case where I need to get the udp port for a service.

[vicyap]

I needed to version lock pytest because I was getting the following error.

RemovedInPytest4Warning: Fixture "docker_services" called directly. Fixtures are not meant to be called directly, are created automatically when test functions request them as parameters. See https://docs.pytest.org/en/latest/fixture.html for more information.

[vicyap]

Okay, I unpinned this requirement.

[butla]

That's a warning, not an error. I think we can live with it for now. We'd need to call the fixtures with one of pytest functions to not invoke that warning. I can't recall that for now, but it's definitely somewhere in the docs related to testing plugins.

Also, putting that range in requirements.in might give the impression that this plugin somehow doesn't support the new pytest.

[butla]

My sample tests (https://github.com/butla/experiments/tree/master/functional_tests) on your branch and the code seems OK.

@vicyap Could you just squash (git rebase -i HEAD~4 while being on the HEAD of your branch) the branch into a single commit?

@AndreLouisCaron Looks good to me, if that matters :)

[vicyap]

Alright, @butla , I squashed my commits

@AndreLouisCaron pending your approval