Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

port_for should allow proto=udp #31

Closed
vicyap opened this issue Nov 19, 2018 · 0 comments
Closed

port_for should allow proto=udp #31

vicyap opened this issue Nov 19, 2018 · 0 comments

Comments

@vicyap
Copy link

vicyap commented Nov 19, 2018

I think it would be useful if https://github.com/AndreLouisCaron/pytest-docker/blob/master/src/pytest_docker/__init__.py#L57 had a proto='tcp' kwarg which allows your to specify the protocol.

For example.

$ docker-compose port
Print the public port for a port binding.

Usage: port [options] SERVICE PRIVATE_PORT

Options:
    --protocol=proto  tcp or udp [default: tcp]
...
@vicyap vicyap changed the title port_for should add a proto kwarg port_for should allow proto=udp Nov 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants