-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add git safe directory to workaround github actions ownership issues #26
Conversation
I'm not sure what I did but coveralls seems to be made at me. |
@AndreMiras Is the failing test expected to fail?
I (my fork) doesn't have access to the COVERALLS_REPO_TOKEN secret, right? |
Thanks for the PR, it looks good to me. Indeed for the repo secret access |
From the original description:
Doing it in the entrypoint would require a subprocess call that just seemed uglier, but if you have strong feelings about it it doesn't matter much to me. I could do something as simple as a |
Ok thanks for the context, no strong feelings at all. I was just curious about what made you change from your original implementation idea |
Closes #25
As discussed in #25, new versions of git check ownership of .git directories. Until github/github actions change how docker-based actions are called, this will cause failures every time coverage/coveralls checks for metadata about the current commit. This PR is the simplest fix I could think of to accomplish this. The alternative would be to add a
subprocess.run
call inentrypoint.py
to run the same command there. I figure since this repository is just a github action and nothing else that doing it in the Dockerfile would be fine.When I use this on my own CI I see:
I'm hoping this is just a hiccup or a threshold from coveralls that they are mad about me restarting the same CI job over and over again.