✅ Tests Container search onError, refs #6

src/components/Container.test.jsx

@@ -1,4 +1,5 @@
 import React from 'react';
+import { ApolloError } from '@apollo/client';
 import { fireEvent, render, screen } from '@testing-library/react';
 import renderer from 'react-test-renderer';
 import { library } from '@fortawesome/fontawesome-svg-core';
@@ -10,30 +11,6 @@ import Container from './Container';
 library.add(fab, fas);
 jest.mock('../utils/search');
 
-const forks = [
-  {
-    nameWithOwner: 'django-nonrel/django',
-    stargazerCount: 214,
-    forkCount: 84,
-    pushedAt: '2020-08-29T14:23:26Z',
-    object: {
-      history: {
-        totalCount: 13990,
-      },
-    },
-  },
-];
-
-const searchResult = {
-  data: {
-    repository: {
-      forks: {
-        nodes: forks,
-      },
-    },
-  },
-};
-
 test('renders', () => {
   const tree = renderer.create(
     <Container />,
@@ -46,12 +23,55 @@ test('search forks', (done) => {
   const searchInput = screen.getByPlaceholderText(/github.com/);
   const submitButton = screen.getByRole('button', { type: 'submit' });
   const forkId = 'django-nonrel/django';
-  searchPopularForks.mockImplementationOnce((url, onResult) => {
+  const forks = [
+    {
+      nameWithOwner: forkId,
+      stargazerCount: 214,
+      forkCount: 84,
+      pushedAt: '2020-08-29T14:23:26Z',
+      object: {
+        history: {
+          totalCount: 13990,
+        },
+      },
+    },
+  ];
+
+  const searchResult = {
+    data: {
+      repository: {
+        forks: {
+          nodes: forks,
+        },
+      },
+    },
+  };
+  searchPopularForks.mockImplementationOnce((url, onResult, onError) => {
     onResult(searchResult);
+    onError; // peaces linter mind
     done();
   });
   expect(screen.queryByText(forkId)).toBeNull();
   fireEvent.change(searchInput, { target: { value: 'https://github.com/django/django' } });
   fireEvent.click(submitButton);
   expect(screen.queryByText(forkId)).toBeInTheDocument();
 });
+
+test('search forks onError', (done) => {
+  render(<Container />);
+  const searchInput = screen.getByPlaceholderText(/github.com/);
+  const submitButton = screen.getByRole('button', { type: 'submit' });
+  const forkId = 'django-nonrel/django-404';
+  const expected = `Could not resolve to a Repository with the name '${forkId}'.`;
+  const searchError = new ApolloError({ errorMessage: expected });
+  searchPopularForks.mockImplementationOnce((url, onResult, onError) => {
+    onResult; // pieaces linter mind
+    onError(searchError);
+    done();
+  });
+  expect(screen.queryByText(forkId)).toBeNull();
+  fireEvent.change(searchInput, { target: { value: `https://github.com/${forkId}` } });
+  expect(screen.queryByText('Error')).not.toBeInTheDocument();
+  fireEvent.click(submitButton);
+  expect(screen.queryByText('Error')).toBeInTheDocument();
+});

src/components/ErrorDialog.jsx

@@ -25,7 +25,7 @@ ErrorDialog.propTypes = {
   onClose: PropTypes.func,
 };
 ErrorDialog.defaultProps = {
-  onClose: () => null,
+  onClose: null,
 };
 
 export default ErrorDialog;