♻️ Query params cleaning

Clean up the query parameters so there's no empty question mark

Makefile

@@ -85,7 +85,7 @@ release/push:
 release: release/prepare release/commit release/push
 
 test:
-	$(BUSTED) --coverage postgrest/
+	$(BUSTED) --verbose --coverage postgrest/
 
 coveralls:
 	$(LUA_COVERALLS) --verbose

README.md

@@ -112,6 +112,17 @@ Delete:
 database:from("todos"):delete():filter{id = 4}:execute()
 ```
 
+## Logger
+
+It's possible to log the requests to the REST API, by passing a request logger callback.
+
+```lua
+function request_logger(method, url, payload, headers)
+    print("method: " .. method .. " url: " .. url)
+end
+database.request_logger = request_logger
+```
+
 ## Development
 
 ### Tests

postgrest/query_builder.lua

@@ -21,7 +21,7 @@ function QueryBuilder:select(columns, ...)
         self.select_columns = {columns, ...}
     end
     self.select_str = #self.select_columns > 0 and "select=" ..
-                          table.concat(self.select_columns, ",") or ""
+                          table.concat(self.select_columns, ",") or nil
     if self.select_str then
         table.insert(self.query_parameters, self.select_str)
     end

postgrest/query_builder_spec.lua

@@ -28,25 +28,31 @@ describe("query_builder", function()
 
         it("should work with empty columns table object", function()
             local expected_columns = {}
-            local expected_select_str = ""
+            local expected_query_parameters = {}
+            local expected_select_str = nil
             local database = nil
             local table_name = nil
             local columns = {}
             local query_builder = QueryBuilder:new(database, table_name)
             query_builder:select(columns)
             assert.same(expected_columns, query_builder.select_columns)
+            assert.same(expected_query_parameters,
+                        query_builder.query_parameters)
             assert.same(expected_select_str, query_builder.select_str)
         end)
 
         it("should work with nil columns object", function()
             local expected_columns = {}
-            local expected_select_str = ""
+            local expected_query_parameters = {}
+            local expected_select_str = nil
             local database = nil
             local table_name = nil
             local columns = nil
             local query_builder = QueryBuilder:new(database, table_name)
             query_builder:select(columns)
             assert.same(expected_columns, query_builder.select_columns)
+            assert.same(expected_query_parameters,
+                        query_builder.query_parameters)
             assert.same(expected_select_str, query_builder.select_str)
         end)
     end)