Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created automatic releases #115

Closed
wants to merge 8 commits into from
Closed

Created automatic releases #115

wants to merge 8 commits into from

Conversation

devedse
Copy link

@devedse devedse commented Mar 21, 2021

Hi @AndreRH and @stefand ,

As I said in my issue I've created a proposal to setup automated releases. Some details and things to think about:

  1. My automated releases trigger on every commit. You could choose to only trigger a release manually. I've set this up for a mod for Valheim before: https://github.com/Loki-Valheim-Modding/loki-valheim/blob/development/.github/workflows/githubactionsbuilds.yml
    I personally like a build on all checkins better, but I'll leave that up to you :).
  2. The version number is automatically increased by 1 for every build. This means that versions go from 1.0.1 to 1.0.2 etc.
  3. The release is only made if all 3 builds are successful.
  4. Currently the build is triggered on both a push to master and a PR. I would advice to only do this on a push to master (as that's something triggered by you). Depending on what you want you could decide on basically skipping the "upping version" number part on normal checkins and only doing this for a manual trigger.

Anyway, I'd love to hear your ideas :).

@devedse
Copy link
Author

devedse commented Mar 21, 2021

Example release I made:
https://github.com/devedse/hangover/actions/runs/673312250

@AndreRH
Copy link
Owner

AndreRH commented Apr 3, 2021

I see the CI/CD thinking behind that, but for now a successful build doesn't justify a new version. Testing hangover is complicated and we need to do it manually. I don't want to have a version out which is fundamentally broken but builds.

@devedse
Copy link
Author

devedse commented Apr 3, 2021

Makes sense, I kindoff expected that. I'll work on building functionality to manually trigger this then.

@AndreRH
Copy link
Owner

AndreRH commented Apr 3, 2021

we don't often release and the process for that is easy enough, so no need for effort

@devedse
Copy link
Author

devedse commented Apr 3, 2021

That's also fine, the thing I would like is to have the 3 build folders in the release output if that's possible. By having that I can more easily setup a docker image of my own which already has hangover installed.

The way I've set this up previously is by having a github actions build that you could manually start and provide a version to it. E.g. you want to release version 1.0.55 you would simply start the build, provide that version and it would create a release with the 3 zip files included. If you want I can really easily automate that for you.

Alternatively you could decide on pushing docker images to the docker hub which include the hangover source + build output without the need of all the build dependencies. (Again, something I could help you automate 😄 )

@AndreRH
Copy link
Owner

AndreRH commented Apr 3, 2021

For https://github.com/AndreRH/hangover/releases/tag/hangover-0.5.15 we haven't had build artifacts enabled, so my assumption was that the upcoming 0.6.x release would automagically have the build assets attached. If that won't be the case, then there's work to do.
Another point of optimization in the actions would be to first build wine-guests (including their dependencies of course) and pass that to the 3 architecture specific builds. The wine-guest builds should be identical anyway (they are done with mingw-64, not with a target platform specific compiler). But there'll be some issues I guess and I am not sure if it's worth the effort...

@devedse
Copy link
Author

devedse commented Apr 7, 2021

I'll leave this PR open until you release version 0.6.x and we'll see if the release includes the build artifacts. I wouldn't mind at all to help you guys further improving the release as I always like working on stuff like that.

@AndreRH AndreRH closed this Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants