-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Created automatic releases #115
Conversation
Example release I made: |
I see the CI/CD thinking behind that, but for now a successful build doesn't justify a new version. Testing hangover is complicated and we need to do it manually. I don't want to have a version out which is fundamentally broken but builds. |
Makes sense, I kindoff expected that. I'll work on building functionality to manually trigger this then. |
we don't often release and the process for that is easy enough, so no need for effort |
That's also fine, the thing I would like is to have the 3 build folders in the release output if that's possible. By having that I can more easily setup a docker image of my own which already has hangover installed. The way I've set this up previously is by having a github actions build that you could manually start and provide a version to it. E.g. you want to release version 1.0.55 you would simply start the build, provide that version and it would create a release with the 3 zip files included. If you want I can really easily automate that for you. Alternatively you could decide on pushing docker images to the docker hub which include the hangover source + build output without the need of all the build dependencies. (Again, something I could help you automate 😄 ) |
For https://github.com/AndreRH/hangover/releases/tag/hangover-0.5.15 we haven't had build artifacts enabled, so my assumption was that the upcoming 0.6.x release would automagically have the build assets attached. If that won't be the case, then there's work to do. |
I'll leave this PR open until you release version 0.6.x and we'll see if the release includes the build artifacts. I wouldn't mind at all to help you guys further improving the release as I always like working on stuff like that. |
Hi @AndreRH and @stefand ,
As I said in my issue I've created a proposal to setup automated releases. Some details and things to think about:
I personally like a build on all checkins better, but I'll leave that up to you :).
Anyway, I'd love to hear your ideas :).