Update main branch fork #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Prevent logging multiple times (because of `onResume()` callback) - Remove unnecessary io dispatcher: `ListenableFuture<T>.await()` is already main-safe and prevent acquiring io slot. - Merge comments into a single javadoc comment on the `ProfileVerifierLogger` type. - Add proper javadoc format with markdown specific blocks. - Update logs & tag to be more uniform. Closes #945
``` :ui-test-hilt-manifest -> ui_test_hilt_manifest_ :core:analytics -> core_analytics_ :core:common -> core_common_ :core:data -> core_data_ :core:data-test -> core_data_test_ :core:database -> core_database_ :core:datastore -> core_datastore_ :core:datastore-test -> core_datastore_test_ :core:designsystem -> core_designsystem_ :core:domain -> core_domain_ :core:network -> core_network_ :core:notifications -> core_notifications_ :core:testing -> core_testing_ :core:ui -> core_ui_ :feature:bookmarks -> feature_bookmarks_ :feature:foryou -> feature_foryou_ :feature:interests -> feature_interests_ :feature:search -> feature_search_ :feature:settings -> feature_settings_ :feature:topic -> feature_topic_ :sync:sync-test -> sync_test_ :sync:work -> sync_work_ ```
- Remove unnecessary nullable types - Replace no-op method bodies with Unit - Convert to expression body - Replace if with when - Remove braces from 'when' entries - Remove braces from if statement - Convert to single line lambda - oneline if/returns - Replace 'contains' call with 'in' operator Following this refactor, it could be great to envision a more "strict" code formatter like ktlint 1.0 (we are currently stuck at 0.48.1)
…e plugin > Since Room 2.6.0, a Gradle plugin was released to solve various existing issues in Room regarding having inputs and outputs of schemas via Gradle annotation processor options. > Changelog: https://developer.android.com/jetpack/androidx/releases/room#2.6.0-alpha02 See gradle/android-cache-fix-gradle-plugin#544 for reference.
- Reduce the visibility of multiple Hilt `Module`s and implementations of public interfaces - Correctly configure the visibility of dependencies: - `api` when it's part of it's public `api` - `implementation` when it's part of it's internal `implementation` - Remove unnecessary dependencies in build.gradle.kts files - Remove unnecessary dependencies provided by plugins - Remove unnecessary applied plugins (i.e. roborazzi) - Sort dependencies in `build.gradle.kts` - Delete unused entries in `libs.versions.toml`
…variant Change-Id: I30126402370162ccbe53e177652583e4472f2030
Change-Id: I5dea4fec5b391e8cb7794af13e99978fcb622fbb
Bumps `coil` from 2.4.0 to 2.5.0. Updates `io.coil-kt:coil` from 2.4.0 to 2.5.0 - [Release notes](https://github.com/coil-kt/coil/releases) - [Changelog](https://github.com/coil-kt/coil/blob/main/CHANGELOG.md) - [Commits](coil-kt/coil@2.4.0...2.5.0) Updates `io.coil-kt:coil-compose` from 2.4.0 to 2.5.0 - [Release notes](https://github.com/coil-kt/coil/releases) - [Changelog](https://github.com/coil-kt/coil/blob/main/CHANGELOG.md) - [Commits](coil-kt/coil@2.4.0...2.5.0) Updates `io.coil-kt:coil-svg` from 2.4.0 to 2.5.0 - [Release notes](https://github.com/coil-kt/coil/releases) - [Changelog](https://github.com/coil-kt/coil/blob/main/CHANGELOG.md) - [Commits](coil-kt/coil@2.4.0...2.5.0) --- updated-dependencies: - dependency-name: io.coil-kt:coil dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: io.coil-kt:coil-compose dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: io.coil-kt:coil-svg dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps `room` from 2.6.0 to 2.6.1. Updates `androidx.room:room-compiler` from 2.6.0 to 2.6.1 Updates `androidx.room:room-ktx` from 2.6.0 to 2.6.1 Updates `androidx.room:room-runtime` from 2.6.0 to 2.6.1 --- updated-dependencies: - dependency-name: androidx.room:room-compiler dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: androidx.room:room-ktx dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: androidx.room:room-runtime dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps the kotlin-ksp-compose group with 7 updates: | Package | From | To | | --- | --- | --- | | androidx.compose.compiler:compiler | `1.5.3` | `1.5.7` | | [org.jetbrains.kotlin:kotlin-stdlib-jdk8](https://github.com/JetBrains/kotlin) | `1.9.10` | `1.9.21` | | [org.jetbrains.kotlin:kotlin-gradle-plugin](https://github.com/JetBrains/kotlin) | `1.9.10` | `1.9.21` | | [org.jetbrains.kotlin.jvm](https://github.com/JetBrains/kotlin) | `1.9.10` | `1.9.21` | | [org.jetbrains.kotlin.plugin.serialization](https://github.com/JetBrains/kotlin) | `1.9.10` | `1.9.21` | | [com.google.devtools.ksp:com.google.devtools.ksp.gradle.plugin](https://github.com/google/ksp) | `1.9.10-1.0.13` | `1.9.21-1.0.16` | | [com.google.devtools.ksp](https://github.com/google/ksp) | `1.9.10-1.0.13` | `1.9.21-1.0.16` | Updates `androidx.compose.compiler:compiler` from 1.5.3 to 1.5.7 Updates `org.jetbrains.kotlin:kotlin-stdlib-jdk8` from 1.9.10 to 1.9.21 - [Release notes](https://github.com/JetBrains/kotlin/releases) - [Changelog](https://github.com/JetBrains/kotlin/blob/master/ChangeLog.md) - [Commits](JetBrains/kotlin@v1.9.10...v1.9.21) Updates `org.jetbrains.kotlin:kotlin-gradle-plugin` from 1.9.10 to 1.9.21 - [Release notes](https://github.com/JetBrains/kotlin/releases) - [Changelog](https://github.com/JetBrains/kotlin/blob/master/ChangeLog.md) - [Commits](JetBrains/kotlin@v1.9.10...v1.9.21) Updates `org.jetbrains.kotlin.jvm` from 1.9.10 to 1.9.21 - [Release notes](https://github.com/JetBrains/kotlin/releases) - [Changelog](https://github.com/JetBrains/kotlin/blob/master/ChangeLog.md) - [Commits](JetBrains/kotlin@v1.9.10...v1.9.21) Updates `org.jetbrains.kotlin.plugin.serialization` from 1.9.10 to 1.9.21 - [Release notes](https://github.com/JetBrains/kotlin/releases) - [Changelog](https://github.com/JetBrains/kotlin/blob/master/ChangeLog.md) - [Commits](JetBrains/kotlin@v1.9.10...v1.9.21) Updates `com.google.devtools.ksp:com.google.devtools.ksp.gradle.plugin` from 1.9.10-1.0.13 to 1.9.21-1.0.16 - [Release notes](https://github.com/google/ksp/releases) - [Commits](google/ksp@1.9.10-1.0.13...1.9.21-1.0.16) Updates `com.google.devtools.ksp` from 1.9.10-1.0.13 to 1.9.21-1.0.16 - [Release notes](https://github.com/google/ksp/releases) - [Commits](google/ksp@1.9.10-1.0.13...1.9.21-1.0.16) --- updated-dependencies: - dependency-name: androidx.compose.compiler:compiler dependency-type: direct:production update-type: version-update:semver-patch dependency-group: kotlin-ksp-compose - dependency-name: org.jetbrains.kotlin:kotlin-stdlib-jdk8 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: kotlin-ksp-compose - dependency-name: org.jetbrains.kotlin:kotlin-gradle-plugin dependency-type: direct:production update-type: version-update:semver-patch dependency-group: kotlin-ksp-compose - dependency-name: org.jetbrains.kotlin.jvm dependency-type: direct:production update-type: version-update:semver-patch dependency-group: kotlin-ksp-compose - dependency-name: org.jetbrains.kotlin.plugin.serialization dependency-type: direct:production update-type: version-update:semver-patch dependency-group: kotlin-ksp-compose - dependency-name: com.google.devtools.ksp:com.google.devtools.ksp.gradle.plugin dependency-type: direct:production update-type: version-update:semver-patch dependency-group: kotlin-ksp-compose - dependency-name: com.google.devtools.ksp dependency-type: direct:production update-type: version-update:semver-patch dependency-group: kotlin-ksp-compose ... Signed-off-by: dependabot[bot] <support@github.com>
Change-Id: Id4271a67ffcfbd712a2dd1f363970fcd31ee5ac0
Bump coil from 2.4.0 to 2.5.0
Bumps `androidxWork` from 2.9.0-rc01 to 2.9.0. Updates `androidx.work:work-runtime-ktx` from 2.9.0-rc01 to 2.9.0 Updates `androidx.work:work-testing` from 2.8.1 to 2.9.0 --- updated-dependencies: - dependency-name: androidx.work:work-runtime-ktx dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: androidx.work:work-testing dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
…mpose-6562232cd5 Bump the kotlin-ksp-compose group with 7 updates
Replace custom `RoomSchemaArgProvider` in favor of the new Room Gradle plugin
…nandroid/core/designsystem/component/scrollbar/ScrollbarExt.kt Co-authored-by: Don Turner <dturner@users.noreply.github.com>
…droid/feature/foryou/navigation/ForYouNavigation.kt
…nandroid/feature/bookmarks/navigation/BookmarksNavigation.kt
…nandroid/feature/interests/navigation/InterestsNavigation.kt
…droid/feature/search/navigation/SearchNavigation.kt
Update Gradle 8.5
Enforce `resourcePrefix` on Android library modules
Add Test for Saved Top Level Destination
'Enum.values()' is recommended to be replaced by 'Enum.entries' since 1.9
The issue has been addressed in `androidx.compose.ui:ui:1.5.0`.
Change-Id: I5f729bce92ec1cc9f71e34e42cbe38765966fc31
Replace workaround on SettingsViewModel now that a fix has been deployed
Add tests for `DesignSystemDetector` lint
Replace `Enum.values()` with `Enum.entries`
Reduce overall build complexity
Merge `lint` dependency version with `androidTools`
... with SVGOM, but you'll have to check on Android Studio the AVD diff. https://googlesamples.github.io/android-custom-lint-rules/checks/VectorPath.md.html
Kotlinify codebase
Optimize AVD to fix long vector paths Lint warning
Extract `ProfileVerifier` logs from `MainActivity` to `NiaApplication`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a pull request. Please include the following information.
What I have done and why
Include a summary of what your pull request contains, and why you have made these changes.
Fixes #<issue_number_goes_here>
Do tests pass?
DemoDebugvariant:./gradlew testDemoDebug./gradlew --init-script gradle/init.gradle.kts spotlessApplyIs this your first pull request?
./tools/setup.sh