Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving ci test #13

Merged
merged 68 commits into from
Jun 15, 2024
Merged

Improving ci test #13

merged 68 commits into from
Jun 15, 2024

Conversation

AndreasArvidsson
Copy link
Owner

No description provided.


export async function launchVscodeAndRunTests() {
try {
const outDirPath = path.join(__dirname, "../../out");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should point to root I believe

Copy link
Owner Author

@AndreasArvidsson AndreasArvidsson Jun 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you are right, but setting extensionDevelopmentPath to root didn't help with the command not found errors

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I guess either way you need to do that tho. It should point to the directory containing your package.json

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe put a log statement in extension activation to be sure it's loading?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a large debug print to the activate function and that is never run.

Copy link
Owner Author

@AndreasArvidsson AndreasArvidsson Jun 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've found the problem. In package.json I had specified that my extension depends on the command server. I didn't install the command server in the test environment so the extension just silently failed to activate. No logs, no nothing the extension just would not activate. . Even words is when I used vscode.extensions.all and looked after my extension it actually had the boolean isActive set to true.

@AndreasArvidsson AndreasArvidsson merged commit 2da464d into develop Jun 15, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants