-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improving ci test #13
Conversation
src/scripts/runTestsCI.ts
Outdated
|
||
export async function launchVscodeAndRunTests() { | ||
try { | ||
const outDirPath = path.join(__dirname, "../../out"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should point to root I believe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you are right, but setting extensionDevelopmentPath
to root didn't help with the command not found errors
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok I guess either way you need to do that tho. It should point to the directory containing your package.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe put a log statement in extension activation to be sure it's loading?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a large debug print to the activate function and that is never run.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've found the problem. In package.json I had specified that my extension depends on the command server. I didn't install the command server in the test environment so the extension just silently failed to activate. No logs, no nothing the extension just would not activate. . Even words is when I used vscode.extensions.all
and looked after my extension it actually had the boolean isActive
set to true.
No description provided.