Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved private template repository docs #311

Merged
merged 4 commits into from
Feb 13, 2023

Conversation

george-gca
Copy link
Contributor

Made clear that there are 2 different solutions for private repos

Signed-off-by: George 31376482+george-gca@users.noreply.github.com

Signed-off-by: George <31376482+george-gca@users.noreply.github.com>
Signed-off-by: George <31376482+george-gca@users.noreply.github.com>
@AndreasAugustin
Copy link
Owner

@george-gca thanks a lot for the PR. Will check ASAP. About the failed builds: those are related because in your forked repo the needed secrets are not set.
I need to fix it within the original repo. Please ignore them for now. Sorry did not think about that issue so far...

Signed-off-by: George <31376482+george-gca@users.noreply.github.com>
@george-gca
Copy link
Contributor Author

Don't worry. I made the pull request and immediately after I realized that some more changes could be made. Finally made them all.

Copy link
Owner

@AndreasAugustin AndreasAugustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@AndreasAugustin AndreasAugustin merged commit 77bb5aa into AndreasAugustin:main Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants