[Fix rubocop#9415] Change Layout/ClassStructure to detect inline mo…

…difiers

changelog/change_class_structure_to_detect_inline_modifiers.md

@@ -0,0 +1 @@
+* [#9415](https://github.com/rubocop-hq/rubocop/issues/9415): Change `Layout/ClassStructure` to detect inline modifiers. ([@AndreiEres][])

lib/rubocop/cop/layout/class_structure.rb

@@ -213,7 +213,12 @@ def find_category(node)
           name = node.method_name.to_s
           category, = categories.find { |_, names| names.include?(name) }
           key = category || name
-          visibility_key = "#{node_visibility(node)}_#{key}"
+          visibility_key =
+            if node.def_modifier?
+              "#{name}_methods"
+            else
+              "#{node_visibility(node)}_#{key}"
+            end
           expected_order.include?(visibility_key) ? visibility_key : key
         end
 
@@ -264,7 +269,7 @@ def humanize_node(node)
 
         def source_range_with_comment(node)
           begin_pos, end_pos =
-            if node.def_type?
+            if node.def_type? || node.send_type? && node.def_modifier?
               start_node = find_visibility_start(node) || node
               end_node = find_visibility_end(node) || node
               [begin_pos_with_comment(start_node),

spec/rubocop/cop/layout/class_structure_spec.rb

@@ -172,9 +172,6 @@ def other_public_method
 
         private :other_public_method
 
-        private def something_inline
-        end
-
         def yet_other_public_method
         end
 
@@ -321,4 +318,52 @@ def do_something
       end
     RUBY
   end
+
+  context 'when def modifier is used' do
+    it 'registers an offense and corrects public method with modifier declared after private method with modifier' do
+      expect_offense(<<~RUBY)
+        class A
+          private def foo
+          end
+
+          public def bar
+          ^^^^^^^^^^^^^^ `public_methods` is supposed to appear before `private_methods`.
+          end
+        end
+      RUBY
+
+      expect_correction(<<~RUBY)
+        class A
+          public def bar
+          end
+
+          private def foo
+          end
+        end
+      RUBY
+    end
+
+    it 'registers an offense and corrects public method without modifier declared after private method with modifier' do
+      expect_offense(<<~RUBY)
+        class A
+          private def foo
+          end
+
+          def bar
+          ^^^^^^^ `public_methods` is supposed to appear before `private_methods`.
+          end
+        end
+      RUBY
+
+      expect_correction(<<~RUBY)
+        class A
+          def bar
+          end
+
+          private def foo
+          end
+        end
+      RUBY
+    end
+  end
 end