Skip to content

Commit

Permalink
[Android] Fixed effects applying to Frame
Browse files Browse the repository at this point in the history
  • Loading branch information
AndreiMisiukevich committed Jun 11, 2019
1 parent 17a60f6 commit 83e640f
Showing 1 changed file with 9 additions and 16 deletions.
25 changes: 9 additions & 16 deletions Xamarin.Forms.Platform.Android/FastRenderers/FrameRenderer.cs
Expand Up @@ -11,7 +11,7 @@

namespace Xamarin.Forms.Platform.Android.FastRenderers
{
public class FrameRenderer : CardView, IVisualElementRenderer, IEffectControlProvider, IViewRenderer, ITabStop
public class FrameRenderer : CardView, IVisualElementRenderer, IViewRenderer, ITabStop
{
float _defaultElevation = -1f;
float _defaultCornerRadius = -1f;
Expand All @@ -23,26 +23,23 @@ public class FrameRenderer : CardView, IVisualElementRenderer, IEffectControlPro

VisualElementPackager _visualElementPackager;
VisualElementTracker _visualElementTracker;
VisualElementRenderer _visualElementRenderer;

readonly GestureManager _gestureManager;
readonly EffectControlProvider _effectControlProvider;
readonly MotionEventHelper _motionEventHelper = new MotionEventHelper();

public event EventHandler<VisualElementChangedEventArgs> ElementChanged;
public event EventHandler<PropertyChangedEventArgs> ElementPropertyChanged;

public FrameRenderer(Context context) : base(context)
{
_gestureManager = new GestureManager(this);
_effectControlProvider = new EffectControlProvider(this);
_visualElementRenderer = new VisualElementRenderer(this);
}

[Obsolete("This constructor is obsolete as of version 2.5. Please use FrameRenderer(Context) instead.")]
[EditorBrowsable(EditorBrowsableState.Never)]
public FrameRenderer() : base(Forms.Context)
{
_gestureManager = new GestureManager(this);
_effectControlProvider = new EffectControlProvider(this);
_visualElementRenderer = new VisualElementRenderer(this);
}

protected CardView Control => this;
Expand Down Expand Up @@ -104,11 +101,6 @@ void IVisualElementRenderer.UpdateLayout()
tracker?.UpdateLayout();
}

void IEffectControlProvider.RegisterEffect(Effect effect)
{
_effectControlProvider.RegisterEffect(effect);
}

void IViewRenderer.MeasureExactly()
{
ViewRenderer.MeasureExactly(this, Element, Context);
Expand All @@ -123,8 +115,6 @@ protected override void Dispose(bool disposing)

if (disposing)
{
_gestureManager?.Dispose();

if (_visualElementTracker != null)
{
_visualElementTracker.Dispose();
Expand All @@ -142,7 +132,10 @@ protected override void Dispose(bool disposing)
_backgroundDrawable.Dispose();
_backgroundDrawable = null;
}


_visualElementRenderer?.Dispose();
_visualElementRenderer = null;

int count = ChildCount;
for (var i = 0; i < count; i++)
{
Expand Down Expand Up @@ -214,7 +207,7 @@ protected override void OnLayout(bool changed, int left, int top, int right, int

public override bool OnTouchEvent(MotionEvent e)
{
if (_gestureManager.OnTouchEvent(e) || base.OnTouchEvent(e))
if (_visualElementRenderer.OnTouchEvent(e) || base.OnTouchEvent(e))
{
return true;
}
Expand Down

0 comments on commit 83e640f

Please sign in to comment.