Skip to content

Commit

Permalink
Forgot to add the parent constraint to the FK chain joints.
Browse files Browse the repository at this point in the history
Removed the fbx file.
Changed back to the class method.
  • Loading branch information
AndresMWeber committed Feb 8, 2018
1 parent aa1e556 commit f01b131
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 9 deletions.
2 changes: 1 addition & 1 deletion anvil/sub_rig_templates/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@ def build_fk_chain(self, chain_start=None, chain_end=None, shape=None, duplicate
chain = nt.HierarchyChain(chain_start, chain_end, duplicate=duplicate, parent=self.group_joints)

# Ensure there are enough shapes in the shape list to pair with the chain

controls = []
last_node = parent or self.group_controls
for node, shape in zip(chain, self.get_shape_list(len(chain), shape)):
Expand All @@ -72,6 +71,7 @@ def build_fk_chain(self, chain_start=None, chain_end=None, shape=None, duplicate
meta_data=self.meta_data.merge(self.meta_data, meta_data, new=True),
**kwargs)
controls.append(control)
rt.dcc.connections.parent(control.connection_group, node, maintainOffset=True)
last_node = control.connection_group
return {cfg.CONTROL_TYPE: controls, cfg.JOINT_TYPE: chain}

Expand Down
12 changes: 4 additions & 8 deletions tests/acceptance/test_build_hand.py
Original file line number Diff line number Diff line change
Expand Up @@ -37,15 +37,11 @@ def from_template_file(cls, template_file, finger_start_joints=None, **kwargs):
class TestBuildHand(TestHandBase):
rig = None

# @classmethod
# def setUpClass(cls):
# super(TestBuildHand, cls).setUpClass()
# cls.rig = cls.from_template_file(cls.HAND_MERC, cls.HAND_MERC_JOINTS)

def setUp(self):
@classmethod
def setUpClass(cls):
super(TestBuildHand, cls).setUpClass()
try:
if self.rig is None:
self.rig = self.from_template_file(self.HAND_MERC, self.HAND_MERC_JOINTS)
cls.rig = cls.from_template_file(cls.HAND_MERC, cls.HAND_MERC_JOINTS)
except IndexError:
print_scene_tree()

Expand Down
Binary file removed tests/acceptance/test_skeleton_hand.fbx
Binary file not shown.

0 comments on commit f01b131

Please sign in to comment.