Switch back to memmove because regions overlap. #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why was it changed to memcpy at all?
|
I think the other errors in #12 (the uninitialized values) are false positives. Except for the leaks. |
Andrettin
added a commit
that referenced
this pull request
Jun 2, 2015
Switch back to memmove because regions overlap.
|
Thanks again :) You really are helping a lot. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The funny that it was memmove originally. And was commented out in a commit with message:
PARALLEL DRAWING THREAD (WELCOME IN MULTITHREADED HELL)