Skip to content

Commit

Permalink
start of adding deprecationwarning for certain low level commands (#476)
Browse files Browse the repository at this point in the history
* start of adding deprecationwarning for certain low level commands
* bumped version to v6.0.0
  • Loading branch information
AndrewAnnex committed Aug 30, 2023
1 parent 0f43e79 commit ed20107
Show file tree
Hide file tree
Showing 5 changed files with 41 additions and 6 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/publish-to-test-and-live-pypi.yml
Expand Up @@ -88,7 +88,7 @@ jobs:
run: |
python -m pip install --upgrade pip
python -m pip install -r ci-requirements.txt
python -m pip install cibuildwheel==2.11.2
python -m pip install cibuildwheel==2.15.0
- name: Build wheels for SpiceyPy 🌶️ 🥧
timeout-minutes: 120
run: |
Expand Down
31 changes: 31 additions & 0 deletions CHANGELOG.md
Expand Up @@ -4,16 +4,46 @@ All notable changes to SpiceyPy will be documented here
The format is based on [Keep a Changelog](http://keepachangelog.com/)
and this project tries to adhere to [Semantic Versioning](http://semver.org/).

## [6.0.0] - 2023-08-30
Fixed several major typos and fortran array ordering issues in tkfram, zzdynrot as well as failing tests on arm64 macos.
### Added
- SpiceNOTENOUGHDATA2 exception #466
- Context manager for SPICE kernels #458
- CITATION.cff file
- DeprecationWarning for zzdynrot

### Changed
- tkfram_c now used in tkfram wrapper function
- updated setup.cfg
- type hints for sincpt to be more correct

### Deprecated
- python 3.6
- python 3.7

### Removed
- codecov as a dependency in dev

### Fixed
- typo in exceptions.rst #459
- fixed test test_sphlat
- fixed sphlat to use correct libspice function call
- fixed tests for dskx02, dskxsi, gfsntc for arm64 macos floating point issues #470
- fixed typo in test_oscelt and test_oscltx


## [5.1.2] - 2022-10-14
fix for exception error message toolkit version
### Fixed
- exceptions now use dynamic lookup of toolkit version for error messages


## [5.1.1] - 2022-07-30
fixes macOS arm64 cross compile
### Fixed
- updated get_spice.py to allow for arch override for macos arm64


## [5.1.0] - 2022-07-09
adds wrappers for the majority of new function in n67
### Added
Expand Down Expand Up @@ -71,6 +101,7 @@ adds wrappers for the majority of new function in n67
- fixed docstring for frinfo
- fixed freebsd support in getspice


## [5.0.1] - 2022-03-23
minor update to make ld_library_path update safer
### Fixed
Expand Down
4 changes: 2 additions & 2 deletions docs/conf.py
Expand Up @@ -65,9 +65,9 @@
# built documents.
#
# The short X.Y version.
version = "5.1.2"
version = "6.0.0"
# The full version, including alpha/beta/rc tags.
release = "5.1.2"
release = "6.0.0"

# The language for content autogenerated by Sphinx. Refer to documentation
# for a list of supported languages.
Expand Down
2 changes: 1 addition & 1 deletion src/spiceypy/__init__.py
Expand Up @@ -22,7 +22,7 @@
SOFTWARE.
"""
__author__ = "AndrewAnnex"
__version__ = "5.1.2"
__version__ = "6.0.0"

from .spiceypy import *
from .utils import support_types
Expand Down
8 changes: 6 additions & 2 deletions src/spiceypy/spiceypy.py
Expand Up @@ -6022,8 +6022,7 @@ def failed() -> bool:
@spice_error_check
def fn2lun(fname: str) -> int:
"""
Internal undocumented command for mapping name of open file to
its FORTRAN (F2C) logical unit.
Map the name of an open file to its associated FORTRAN (F2C) logical unit.

https://naif.jpl.nasa.gov/pub/naif/toolkit_docs/FORTRAN/spicelib/fn2lun.html

Expand Down Expand Up @@ -17040,6 +17039,11 @@ def zzdynrot(typid: int, center: int, et: float) -> Tuple[ndarray, int]:
:param et: Epoch measured in seconds past J2000
:return: Rotation matrix from the input frame to the returned associated frame, id for the associated frame
"""
warnings.warn(
f'zzdynrot is a "private routine" for spice. Users should avoid using it. It may disappear in future releases after v6.0.0',
DeprecationWarning,
stacklevel=2,
)
typid = ctypes.c_int(typid)
center = ctypes.c_int(center)
et = ctypes.c_double(et)
Expand Down

0 comments on commit ed20107

Please sign in to comment.