Objective-C Backwards Compatibility #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
insanj
commented
Dec 25, 2017
| @@ -505,6 +505,7 @@ | |||
| GCC_WARN_UNUSED_VARIABLE = YES; | |||
| IPHONEOS_DEPLOYMENT_TARGET = 10.0; | |||
| MTL_ENABLE_DEBUG_INFO = NO; | |||
| ONLY_ACTIVE_ARCH = YES; | |||
| SDKROOT = iphoneos; | |||
There was a problem hiding this comment.
Needed for Travis. Scheme should set this to NO when building framework for release.
|
Hey man, sorry I was away. This looks great, just a couple of things to add. So I created a develop branch off of master and added a CHANGELOG. Could you instead PR these changes off of develop, and then add a change to the CHANGELOG? I greatly appreciate your contributions, thank you. |
|
@insanj Finally got around to this, been one hell of a year lol In case you are still interested, I'm closing this PR, and pushing out a PR and version today for these changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.