Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Look into feasibility of obtaining directory change notifications #48

Closed
AndrewDWhite opened this issue Jun 16, 2020 · 2 comments
Closed

Look into feasibility of obtaining directory change notifications #48

AndrewDWhite opened this issue Jun 16, 2020 · 2 comments
Labels
Planning/Research

Comments

@AndrewDWhite
Copy link
Owner

Look into feasibility of obtaining directory change notifications to reduce hit in performance against system. This kind of feature would be needed to sustainably support a hashing feature.
https://docs.microsoft.com/en-us/windows/win32/fileio/obtaining-directory-change-notifications
@AndrewDWhite AndrewDWhite changed the title Look into fesability of obtaining directory change notifications Look into feasibility of obtaining directory change notifications Jun 16, 2020
@AndrewDWhite
Copy link
Owner Author

See the monitor branch for ideas of how this might happen.
https://github.com/AndrewDWhite/GalaxyGenericImporterPlugin/tree/monitor

This was referenced Jun 19, 2020
Merged
Merged
AndrewDWhite added a commit that referenced this issue Jun 19, 2020
@AndrewDWhite
Merge pull request #51 from AndrewDWhite/dev
8fcc5ee 
Implemented using directory change notifications to reduce the amount of scans of folders. #48
More can be done for this to further reduce this by limiting the reads to the sections changed.
@AndrewDWhite
Copy link
Owner Author

More can be done to improve the initial version of this.

@AndrewDWhite AndrewDWhite mentioned this issue Jun 19, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Planning/Research
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@AndrewDWhite