InfoLabel includes additional heading data #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2019 update
This eliminates an xcode compile warning
Was CLLocationDegrees, now CLLocationDirection. Worth noting that both are doubles so the code compiled w/o error, but it's now correct.
…ly after pause/resume Was ARWorldTracdkingConfiguration, now AROrientationTrackingConfiguration. Heading (Euler.y) now tracks soley to AHRS, before it tried to sense and track to planes - which doesn't make sense for an outside environment.
…acking. The default is World Tracking.
…re-commented it. Also addressed an issue Marc found in the PR.
Adds the ability to specify World Tracking vs. Orientation Tracking
This reverts commit 95d4ca0.
…ing.headingAccuracy to help debug heading issues Also infoLabel uses a monospaced font to reduce jitter
intere
approved these changes
Jun 22, 2019
|
Great work @Pilot-Marc! |
Pilot-Marc
added a commit
to Pilot-Marc/ARKit-CoreLocation
that referenced
this pull request
Jun 23, 2019
* App Store 1024x1024 Icon This eliminates an xcode compile warning * Fix CLHeading.headingAccuracy variable definition Was CLLocationDegrees, now CLLocationDirection. Worth noting that both are doubles so the code compiled w/o error, but it's now correct. * Camera tracking mechanism sync to device orientation better, especially after pause/resume Was ARWorldTracdkingConfiguration, now AROrientationTrackingConfiguration. Heading (Euler.y) now tracks soley to AHRS, before it tried to sense and track to planes - which doesn't make sense for an outside environment. * Added a configuration option for World Tracking versus Orientation Tracking. The default is World Tracking. * Updated the changelog. * Added more (defaulted) parameters to the convenience initializer and re-commented it. Also addressed an issue Marc found in the PR. * Comments on how to use the new aRTrackingType option * Revert "Comments on how to use the new aRTrackingType option" This reverts commit 95d4ca0. * InfoLabel displays ARKit.EulerAngles.y, CLHeading.heading, and CLHeading.headingAccuracy to help debug heading issues Also infoLabel uses a monospaced font to reduce jitter
intere
pushed a commit
that referenced
this pull request
Jun 23, 2019
* App Store 1024x1024 Icon This eliminates an xcode compile warning * Fix CLHeading.headingAccuracy variable definition Was CLLocationDegrees, now CLLocationDirection. Worth noting that both are doubles so the code compiled w/o error, but it's now correct. * Camera tracking mechanism sync to device orientation better, especially after pause/resume Was ARWorldTracdkingConfiguration, now AROrientationTrackingConfiguration. Heading (Euler.y) now tracks soley to AHRS, before it tried to sense and track to planes - which doesn't make sense for an outside environment. * Added a configuration option for World Tracking versus Orientation Tracking. The default is World Tracking. * Updated the changelog. * Added more (defaulted) parameters to the convenience initializer and re-commented it. Also addressed an issue Marc found in the PR. * Comments on how to use the new aRTrackingType option * Revert "Comments on how to use the new aRTrackingType option" This reverts commit 95d4ca0. * Remove flicker by assigning non-conflicting z-order values to each node * Convert TAB -> Space * Convert TAB -> Space * InfoLabel includes additional heading data (#203) * App Store 1024x1024 Icon This eliminates an xcode compile warning * Fix CLHeading.headingAccuracy variable definition Was CLLocationDegrees, now CLLocationDirection. Worth noting that both are doubles so the code compiled w/o error, but it's now correct. * Camera tracking mechanism sync to device orientation better, especially after pause/resume Was ARWorldTracdkingConfiguration, now AROrientationTrackingConfiguration. Heading (Euler.y) now tracks soley to AHRS, before it tried to sense and track to planes - which doesn't make sense for an outside environment. * Added a configuration option for World Tracking versus Orientation Tracking. The default is World Tracking. * Updated the changelog. * Added more (defaulted) parameters to the convenience initializer and re-commented it. Also addressed an issue Marc found in the PR. * Comments on how to use the new aRTrackingType option * Revert "Comments on how to use the new aRTrackingType option" This reverts commit 95d4ca0. * InfoLabel displays ARKit.EulerAngles.y, CLHeading.heading, and CLHeading.headingAccuracy to help debug heading issues Also infoLabel uses a monospaced font to reduce jitter * Update ChangeLog for PR 203
alexbartisro
pushed a commit
to alexbartisro/ARKit-CoreLocation
that referenced
this pull request
Jul 3, 2019
* App Store 1024x1024 Icon This eliminates an xcode compile warning * Fix CLHeading.headingAccuracy variable definition Was CLLocationDegrees, now CLLocationDirection. Worth noting that both are doubles so the code compiled w/o error, but it's now correct. * Camera tracking mechanism sync to device orientation better, especially after pause/resume Was ARWorldTracdkingConfiguration, now AROrientationTrackingConfiguration. Heading (Euler.y) now tracks soley to AHRS, before it tried to sense and track to planes - which doesn't make sense for an outside environment. * Added a configuration option for World Tracking versus Orientation Tracking. The default is World Tracking. * Updated the changelog. * Added more (defaulted) parameters to the convenience initializer and re-commented it. Also addressed an issue Marc found in the PR. * Comments on how to use the new aRTrackingType option * Revert "Comments on how to use the new aRTrackingType option" This reverts commit 95d4ca0. * InfoLabel displays ARKit.EulerAngles.y, CLHeading.heading, and CLHeading.headingAccuracy to help debug heading issues Also infoLabel uses a monospaced font to reduce jitter
alexbartisro
pushed a commit
to alexbartisro/ARKit-CoreLocation
that referenced
this pull request
Jul 3, 2019
* App Store 1024x1024 Icon This eliminates an xcode compile warning * Fix CLHeading.headingAccuracy variable definition Was CLLocationDegrees, now CLLocationDirection. Worth noting that both are doubles so the code compiled w/o error, but it's now correct. * Camera tracking mechanism sync to device orientation better, especially after pause/resume Was ARWorldTracdkingConfiguration, now AROrientationTrackingConfiguration. Heading (Euler.y) now tracks soley to AHRS, before it tried to sense and track to planes - which doesn't make sense for an outside environment. * Added a configuration option for World Tracking versus Orientation Tracking. The default is World Tracking. * Updated the changelog. * Added more (defaulted) parameters to the convenience initializer and re-commented it. Also addressed an issue Marc found in the PR. * Comments on how to use the new aRTrackingType option * Revert "Comments on how to use the new aRTrackingType option" This reverts commit 95d4ca0. * Remove flicker by assigning non-conflicting z-order values to each node * Convert TAB -> Space * Convert TAB -> Space * InfoLabel includes additional heading data (AndrewHartAR#203) * App Store 1024x1024 Icon This eliminates an xcode compile warning * Fix CLHeading.headingAccuracy variable definition Was CLLocationDegrees, now CLLocationDirection. Worth noting that both are doubles so the code compiled w/o error, but it's now correct. * Camera tracking mechanism sync to device orientation better, especially after pause/resume Was ARWorldTracdkingConfiguration, now AROrientationTrackingConfiguration. Heading (Euler.y) now tracks soley to AHRS, before it tried to sense and track to planes - which doesn't make sense for an outside environment. * Added a configuration option for World Tracking versus Orientation Tracking. The default is World Tracking. * Updated the changelog. * Added more (defaulted) parameters to the convenience initializer and re-commented it. Also addressed an issue Marc found in the PR. * Comments on how to use the new aRTrackingType option * Revert "Comments on how to use the new aRTrackingType option" This reverts commit 95d4ca0. * InfoLabel displays ARKit.EulerAngles.y, CLHeading.heading, and CLHeading.headingAccuracy to help debug heading issues Also infoLabel uses a monospaced font to reduce jitter * Update ChangeLog for PR 203
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Added line to InfoLabel to display ARKit's heading value (EulerAngles.y), and CoreLocation's heading values (CLHeading.heading and CLHeading.headingAccuracy), all displayed in degrees. This'll help diagnose heading related issues. Also, the font for the InfoLabel is now monospaced to remove the jitter
Breaking Changes
N/A
Meta
Checklist
open, andpublicscoped methods and properties.Screenshots