Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
POIViewController was being retained in memory, causing the app's memory footprint to grow each time the POIViewController page was loaded.
Breaking Changes
iOS 9 and iOS 10 installations could see a run-time assert, but I don't think there's any way to get to the asserted routine in this circumstance. Regardless, the framework is about to lose iOS 9 and iOS 10 support anyway.
Meta
PR Checklist
open
, andpublic
scoped methods and properties.Screenshots
Before Screenshot - Showing three invocations of POIViewController:
After Screenshot - Showing three invocations of POIViewController: