Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Memory Leak #249

Merged
merged 3 commits into from
Nov 24, 2019
Merged

Fix Memory Leak #249

merged 3 commits into from
Nov 24, 2019

Conversation

Pilot-Marc
Copy link
Collaborator

@Pilot-Marc Pilot-Marc commented Nov 24, 2019

Background

POIViewController was being retained in memory, causing the app's memory footprint to grow each time the POIViewController page was loaded.

  • Three NSTimer calls were modified to use weak references to self.
  • Two NSNotification callbacks were modified to use weak references to self.

Breaking Changes

iOS 9 and iOS 10 installations could see a run-time assert, but I don't think there's any way to get to the asserted routine in this circumstance. Regardless, the framework is about to lose iOS 9 and iOS 10 support anyway.

Meta

  • Tied to Version Release(s): N/A.

PR Checklist

  • CI runs clean?
  • Appropriate label has been added to this PR (i.e., Bug, Enhancement, etc.).
  • Documentation has been added to all open, and public scoped methods and properties.
  • Changelog has been updated
  • Tests have have been added to all new features. (not a requirement, but helpful)
  • Image/GIFs have been added for all UI related changed.

Screenshots

Before Screenshot - Showing three invocations of POIViewController:

After Screenshot - Showing three invocations of POIViewController:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants