Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded the lodash version to fix Prototype Pollution vulnerability (CVE-2019-10744) #98

Merged
merged 4 commits into from
Aug 1, 2019
Merged

Conversation

apoorvmalhotra
Copy link
Contributor

@apoorvmalhotra apoorvmalhotra commented Jul 29, 2019

Upgraded the lodash version to fix Prototype Pollution vulnerability (CVE-2019-10744)
Please refer to https://app.snyk.io/vuln/SNYK-JS-LODASH-450202

@apoorvmalhotra
Copy link
Contributor Author

@AndrewKeig have time for a quick review?

@colthreepv
Copy link

It LGTM for me, this library does not have any invocation of defaultsDeep, the function reported to achieve prototype pollution.

If tests run I would give a green light

@apoorvmalhotra
Copy link
Contributor Author

Thanks @colthreepv. This has been flagged as one of the security vulnerabilities in my project as I use the express-validation library. Can you please publish a new version as well with this change?

@apoorvmalhotra
Copy link
Contributor Author

@colthreepv @AndrewKeig can you please merge this PR and create a new package?

@isaachinman
Copy link

@apoorvmalhotra First, the caret means you can install any minor/patch off v4 already. Second, this PR has conflicts and will not be considered until you resolve them.

package.json Outdated Show resolved Hide resolved
@isaachinman isaachinman merged commit 38e31a6 into AndrewKeig:master Aug 1, 2019
@apoorvmalhotra apoorvmalhotra deleted the loadashUpgrade branch August 1, 2019 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants