test: added tests for configuration.

Signed-off-by: Andrew Neudegg <andrew.neudegg@finbourne.com>

pkg/configuration/config_test.go

@@ -0,0 +1,71 @@
+package configuration
+
+import (
+	"testing"
+
+	"github.com/stretchr/testify/assert"
+)
+
+func TestConfigurationSimple(t *testing.T) {
+	config := []byte(`
+applicationSettings: {}
+sourceConfigurations:
+  - name: http/simple
+    config:
+      ListenAddr: :5050
+      MaxBodySize: 512
+relayConfigs:
+  - name: memory
+    config: {}
+distributorConfigurations:
+  - name: http/direct
+    config:
+      Addr: http://localhost:5051
+`)
+	c := RawConfig{
+		ConfigData: config,
+	}
+	lC, err := c.Load()
+	assert.Nil(t, err)
+
+	assert.Equal(t, lC.SourceConfigs[0].Name, "http/simple")
+	assert.Equal(t, lC.RelayConfigs[0].Name, "memory")
+	assert.Equal(t, lC.DistributorConfigs[0].Name, "http/direct")
+}
+
+func TestConfigurationSubConfigs(t *testing.T) {
+	config := []byte(`
+applicationSettings: {}
+sourceConfigurations:
+  - name: mock/config
+    config: {}
+    subConfigs: 
+    - name: example/example1
+      config:
+        ListenAddr: :5050
+        MaxBodySize: 512
+    - name: example/example2
+      config:
+        ListenAddr: :5050
+        MaxBodySize: 512
+relayConfigs:
+  - name: memory
+    config: {}
+distributorConfigurations:
+  - name: http/direct
+    config:
+      Addr: http://localhost:5051
+`)
+	c := RawConfig{
+		ConfigData: config,
+	}
+	lC, err := c.Load()
+	assert.Nil(t, err)
+
+	assert.Equal(t, lC.SourceConfigs[0].Name, "mock/config")
+	assert.Equal(t, lC.RelayConfigs[0].Name, "memory")
+	assert.Equal(t, lC.DistributorConfigs[0].Name, "http/direct")
+
+	assert.Equal(t, lC.SourceConfigs[0].SubConfigs[0].Name, "example/example1")
+	assert.Equal(t, lC.SourceConfigs[0].SubConfigs[1].Name, "example/example2")
+}

pkg/configuration/file_test.go

@@ -38,7 +38,7 @@ distributorConfigurations:
     B: example
 `)
 
-func TestSmoke(t *testing.T) {
+func TestFileSmoke(t *testing.T) {
 	// Setup
 	dir, err := ioutil.TempDir("", "config")
 	if err != nil {
@@ -65,3 +65,36 @@ func TestSmoke(t *testing.T) {
 	assert.Equal(t, "first", sourceConfigs[0].Name)
 	assert.Equal(t, "second", sourceConfigs[1].Name)
 }
+
+func TestBadFile(t *testing.T) {
+	// Setup
+	fConfig := FileConfig{
+		Source: "doesnt-exist",
+	}
+
+	_, err := fConfig.Load()
+	assert.Error(t, err)
+}
+
+func TestBadFileContent(t *testing.T) {
+	testBytes := append([]byte("testing"), exampleConfig...)
+
+	// Setup
+	dir, err := ioutil.TempDir("", "config")
+	if err != nil {
+		t.Fatal(err)
+	}
+	defer os.RemoveAll(dir) // clean up
+	tmpfn := filepath.Join(dir, "config.yaml")
+	if err := ioutil.WriteFile(tmpfn, testBytes, 0666); err != nil {
+		t.Fatal(err)
+	}
+
+	// -- Test --
+	fConfig := FileConfig{
+		Source: tmpfn,
+	}
+
+	_, err = fConfig.Load()
+	assert.Error(t, err)
+}

pkg/configuration/raw_test.go

@@ -0,0 +1,55 @@
+package configuration
+
+import (
+	"testing"
+
+	"github.com/stretchr/testify/assert"
+)
+
+var rawExampleConfig = []byte(`
+applicationSettings: {}
+
+# sourceConfigurations
+sourceConfigurations:
+- name: first
+  sourceConfig:
+    A: example
+    B: example
+- name: second
+  sourceConfig:
+    A: example
+    B: example
+
+# relayConfigs
+relayConfigs:
+- name: thing
+  sourceConfig:
+    A: example
+    B: example
+
+# distributorConfigurations
+distributorConfigurations:
+- name: thing
+  sourceConfig:
+    A: example
+    B: example
+`)
+
+func TestRawSmoke(t *testing.T) {
+	f := RawConfig{
+		ConfigData: rawExampleConfig,
+	}
+
+	_, err := f.Load()
+	assert.Nil(t, err)
+}
+
+func TestRawBadData(t *testing.T) {
+	testBytes := append([]byte("testing"), rawExampleConfig...)
+	f := RawConfig{
+		ConfigData: testBytes,
+	}
+
+	_, err := f.Load()
+	assert.Error(t, err)
+}

pkg/configuration/structs.go

@@ -21,7 +21,7 @@ type AppSettings struct{}
 
 // NodeConfig defines the configuration for any given pluggable structure.
 type NodeConfig struct {
-	Name        string                 `yaml:"name"`
-	Config      map[string]interface{} `yaml:"config"`
-	NodeConfigs []*NodeConfig          `yaml:"nodeConfigs"`
+	Name       string                 `yaml:"name"`
+	Config     map[string]interface{} `yaml:"config"`
+	SubConfigs []*NodeConfig          `yaml:"subConfigs"`
 }