This repository has been archived by the owner on Jan 29, 2023. It is now read-only.
Fix HTML from being stripped from pasted text #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @martamius I'll go ahead and merge this change. However note that this library is currently considered unmaintained until someone can be found who is able to dedicate the required time into it. |
|
Hi @martamius, Thanks for your contribution. I will see that this is published to npm some time today after some tests. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As described in #34, HTML tags were being stripped from pasted text. This is due to using the
insertHTML()function to insert the text. Because we were usinginsertHTML(), the browser was attempting to interpret the pasted HTML as markup, and was stripping it out of the JSON.This PR simply changes to using the
insertText()function instead so the pasted text is inserted as-is without being interpreted by the browser.Testing
Copy text containing HTML markup into a JSON string. Note that tags are no longer stripped.