Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for choosing listening host for Flask #5

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

lstep
Copy link

@lstep lstep commented Feb 15, 2024

If the server is on a remote machine, allows to set a listening ip/hostname, otherwise, only runs on 127.0.0.1.
Set it by default to 127.0.0.1 for security

@AndrewVeee
Copy link
Owner

Thanks, this is great, I really appreciate the contribution!

I did notice one issue - the config fails to load because the IP needs to be quoted, eg:
server_host = "127.0.0.1"

I hope I don't regret choosing toml - it's supposed to be a simpler config format, but it's not used much.

@AndrewVeee AndrewVeee merged commit 9249093 into AndrewVeee:main Feb 16, 2024
@AndrewVeee
Copy link
Owner

Actually, no big deal, I merged this and then updated the config.

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants