Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adpat new tailwindcss tokens #95

Merged
merged 26 commits into from
Nov 6, 2021
Merged

feat: adpat new tailwindcss tokens #95

merged 26 commits into from
Nov 6, 2021

Conversation

Andrewnt219
Copy link
Owner

@Andrewnt219 Andrewnt219 commented Nov 4, 2021 •
edited
Loading

Resolves #80 .

You can read the changes if you want, but I recommend only checking the new UI from preview deployment

@vercel
Copy link

vercel bot commented Nov 4, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/andrewnt219/rent-near-me/F17NR5K6ocopNTF7JNKByVrwt4MR
✅ Preview: https://rent-near-me-git-78-add-alert-component-andrewnt219.vercel.app

@Andrewnt219 Andrewnt219 changed the title fix: missing tailwindcss tokens fix: adpat new tailwindcss tokens Nov 4, 2021
@Andrewnt219 Andrewnt219 linked an issue Nov 4, 2021 that may be closed by this pull request
Update tailwindcss tokens for Minimals #80
Closed
6 tasks
@Andrewnt219 Andrewnt219 changed the title fix: adpat new tailwindcss tokens feat: adpat new tailwindcss tokens Nov 4, 2021
vitokhangnguyen
vitokhangnguyen requested changes Nov 5, 2021
View reviewed changes
Copy link
Collaborator

@vitokhangnguyen vitokhangnguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a lot of work. Great job!

@types/twin.d.ts Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
src/modules/account/components/AccountMenu/AccountMenu.tsx Outdated Show resolved Hide resolved
src/ui/Modal/Modal.tsx Show resolved Hide resolved
src/ui/Modal/Modal.tsx Show resolved Hide resolved
src/modules/layouts/components/UserMenu/UserMenu.tsx Outdated Show resolved Hide resolved
src/ui/Text/Text.tsx Outdated Show resolved Hide resolved
vitokhangnguyen
vitokhangnguyen requested changes Nov 5, 2021
View reviewed changes
Copy link
Collaborator

@vitokhangnguyen vitokhangnguyen left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Styling suggestion: The shadow of the navbar should be more prominenet. Besides that, the UI quality seems impreoved by a lot with thje new sstyle system

image

image

@vitokhangnguyen
Copy link
Collaborator

Ehhh... not sure if you're done but the logo is different now

image

@vitokhangnguyen vitokhangnguyen mentioned this pull request Nov 5, 2021
Closed
@Andrewnt219
Copy link
Owner Author

@vitokhangnguyen Reverted.

vitokhangnguyen
vitokhangnguyen approved these changes Nov 6, 2021
View reviewed changes
Copy link
Collaborator

@vitokhangnguyen vitokhangnguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just made a small change to use the Airbnb logo for the "Create a new account" button in the LoginForm. This's gonna be the placeholder for our logo when we have one.

@Andrewnt219 Andrewnt219 merged commit de01b29 into clone-minimals Nov 6, 2021
@vitokhangnguyen vitokhangnguyen deleted the 78-add-alert-component branch November 6, 2021 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vitokhangnguyen vitokhangnguyen vitokhangnguyen approved these changes

Assignees

@Andrewnt219 Andrewnt219

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update tailwindcss tokens for Minimals
2 participants
@Andrewnt219 @vitokhangnguyen