Sign-In through android and desktop webview #90

mboukadir · 2022-12-04T01:20:55Z

📑 What does this PR do?

The login is done through a Webview. So I set up two implementations of the Webview, one on Android and the second on desktop.

The pr aims to identify a viable solution to use a Webview on a desktop. For this, I used JavaFX without going through the official plugin because it is not currently possible to use it in the module alongside the Android Library plugin.

✅ Checklist

My pull request adheres to the code style of this project
My code requires changes to the documentation
I have updated the documentation as required
All the tests have passed

🧪 How can this PR been tested?

🧾 Tasks Remaining: (List of tasks remaining to be implemented)

Find a viable solution to use webview on desktop
Look at all the places where I put TODO 😬

🖼️ Screenshots (if applicable):

Screen.Recording.2022-12-04.at.02.25.03.mov

crocsandcoffee

Overall looks good! Just did a quick first pass to get you some early feedback

...rc/commonMain/kotlin/social/androiddev/signedout/navigation/DefaultSignedOutRootComponent.kt

ui/common/src/androidMain/kotlin/social/androiddev/common/composables/webview/SignInWebview.kt

mboukadir · 2022-12-04T22:01:15Z

Overall looks good! Just did a quick first pass to get you some early feedback

Thank you @crocsandcoffee for your feedback which I have taken into account. Tell me if I can switch the pr to non-draft

ui/common/build.gradle.kts

ui/common/src/commonMain/kotlin/social/androiddev/common/composables/webview/SignInViewModel.kt

ui/common/src/commonMain/kotlin/social/androiddev/common/composables/webview/SignInWebview.kt

ui/signed-out/src/commonMain/kotlin/social/androiddev/signedout/composables/SignInContent.kt

mboukadir · 2022-12-05T22:07:17Z

@crocsandcoffee for your information, I moved the sign-in webview, from the common module to the signed-out module because its implementation is specific to the sign-in use case.

I changed the structure of the packages in the signed-out module to have a package-by-step (landing, sign-in). I would like to know what you think about it.

crocsandcoffee

Looks good, let's go ahead and move this out of draft

ui/signed-out/build.gradle.kts

ui/signed-out/src/androidMain/kotlin/social/androiddev/signedout/signin/SignInWebView.kt

ui/signed-out/src/desktopMain/kotlin/social/androiddev/signedout/signin/SingInWebView.kt

ui/signed-out/src/commonMain/kotlin/social/androiddev/signedout/signin/SignInContent.kt

crocsandcoffee · 2022-12-06T02:13:16Z

@crocsandcoffee for your information, I moved the sign-in webview, from the common module to the signed-out module because its implementation is specific to the sign-in use case.

I changed the structure of the packages in the signed-out module to have a package-by-step (landing, sign-in). I would like to know what you think about it.

Yes, I missed that in the first pass of the draft review, it definitely makes sense to move it from common to signed-out module. We can of course create a more general WebView composable in the common module and have the "SignInWebView" call that if we want.

Also the package structure in the signed-out module sounds good

build.gradle.kts

krizzu

Great work 👏

crocsandcoffee reviewed Dec 4, 2022

View reviewed changes

mboukadir force-pushed the feature/signin-through-android-desktop-webview branch from 8e7fbe2 to 6faf9e3 Compare December 4, 2022 22:07