Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: app crashed if filename empty #1322

Closed
2 tasks done
ask9027 opened this issue Sep 19, 2023 · 0 comments
Closed
2 tasks done

[Bug]: app crashed if filename empty #1322

ask9027 opened this issue Sep 19, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@ask9027
Copy link

ask9027 commented Sep 19, 2023

What happened?

if i want to create any activity, class or interface etc. in root packages com.example.myapp and leave filename empty IDE crased.

What's the expected behavior?

should show an error if filename is empty.

What version of AndroidIDE you're using?

v2.5.2 (debug builds)

Relevant log output

AndroidIDE crash report
Manufacturer: Xiaomi
Device: M2101K9AI
ABI: arm64-v8a
SDK version: 33
App version: v2.5.3-beta.internal.1+branch.dev.commit.de2341a.timestamp.20230918141333 (253)

 Stacktrace: 
java.lang.IllegalArgumentException: not a valid name: 
	at com.squareup.javapoet.Util.checkArgument(Util.java:89)
	at com.squareup.javapoet.TypeSpec$Builder.<init>(TypeSpec.java:439)
	at com.squareup.javapoet.TypeSpec$Builder.<init>(Unknown Source:0)
	at com.squareup.javapoet.TypeSpec.classBuilder(TypeSpec.java:129)
	at com.itsaky.androidide.utils.ClassBuilder.newClassSpec(ClassBuilder.kt:48)
	at com.itsaky.androidide.utils.ClassBuilder.createClass(ClassBuilder.kt:33)
	at com.itsaky.androidide.utils.ProjectWriter.createJavaClass(ProjectWriter.java:107)
	at com.itsaky.androidide.actions.filetree.NewFileAction.createJavaClass$lambda$2(NewFileAction.kt:181)
	at com.itsaky.androidide.actions.filetree.NewFileAction.$r8$lambda$CSWYnF4_OPtmJYQTSZ9jAAWEkFY(Unknown Source:0)
	at com.itsaky.androidide.actions.filetree.NewFileAction$$ExternalSyntheticLambda2.onClick(Unknown Source:12)
	at androidx.appcompat.app.AlertController$ButtonHandler.handleMessage(AlertController.java:167)
	at android.os.Handler.dispatchMessage(Handler.java:106)
	at android.os.Looper.loopOnce(Looper.java:211)
	at android.os.Looper.loop(Looper.java:300)
	at android.app.ActivityThread.main(ActivityThread.java:8296)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:559)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:954)

Duplicate issues

  • This issue has not been reported yet.

Code of Conduct

  • I agree to follow this project's Code of Conduct
@ask9027 ask9027 added the bug Something isn't working label Sep 19, 2023
@itsaky itsaky closed this as completed in 047956b Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant