Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: 'Save' action should be disabled if the file save operation is in progress #1391

Closed
2 tasks done
itsaky opened this issue Oct 22, 2023 · 1 comment · Fixed by #1470
Closed
2 tasks done

[Bug]: 'Save' action should be disabled if the file save operation is in progress #1391

itsaky opened this issue Oct 22, 2023 · 1 comment · Fixed by #1470
Labels
bug Something isn't working
Milestone
v2.6.1-beta

Comments

@itsaky
Copy link
Member

itsaky commented Oct 22, 2023

What happened?

Currently, if the user has opened a large file or the saving the file takes a long time, the 'Save' action in the toolbar is not disabled which can lead to multiple save tasks being started by the user.

What's the expected behavior?

The 'Save' action should be disabled if the files are being saved.

What version of AndroidIDE you're using?

v2.5.3 (debug builds)

Relevant log output

No response

Duplicate issues

  • This issue has not been reported yet.

Code of Conduct

  • I agree to follow this project's Code of Conduct
@itsaky itsaky added the bug Something isn't working label Oct 22, 2023
@ask9027
Copy link

ask9027 commented Oct 22, 2023

please, place save button after run button , so user can easily save file instead of save from menu button.

@itsaky itsaky added this to the v2.6.1-beta milestone Nov 14, 2023
@teixeira0x teixeira0x mentioned this issue Nov 15, 2023
Merged
@itsaky itsaky linked a pull request Nov 16, 2023 that will close this issue
fix(actions): disable the save action if there is a save operation in progress. #1470
Merged
itsaky added a commit that referenced this issue Nov 17, 2023
@teixeira0x @itsaky
fix(actions/save): disable the save action if there is a save operati…
bb8bc09 
…on in progress (#1470)

Fixes #1391.

Co-authored-by: Akash Yadav <itsaky01@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v2.6.1-beta
Development

Successfully merging a pull request may close this issue.

fix(actions): disable the save action if there is a save operation in progress.
2 participants
@itsaky @ask9027