Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dismissing windows whenever editor loses focus #494

Merged
merged 1 commit into from Oct 3, 2022
Merged

dismissing windows whenever editor loses focus #494

merged 1 commit into from Oct 3, 2022

Conversation

Devendra34
Copy link
Contributor

Fixes #490
Whenever IDEEditor loses its focus, all the windows associated with it will be dismissed automatically. Earlier it has to be done manually by explicitly calling ensureWindowsDismissed() from outside.

@Devendra34
Copy link
Contributor Author

You need to sign your commits before I can merge them. Learn more about signing commits here.

Hi @itsaky, as requested by you, I have signed my commit in this PR.
Thanks for the links!

@itsaky
Copy link
Member

itsaky commented Oct 3, 2022

Looks good. Will merge it after the checks are completed.

@itsaky itsaky added the hacktoberfest-accepted Indicates that a PR was accepted as part of the Hacktoberfest event. label Oct 3, 2022
@itsaky itsaky merged commit 4e9811b into AndroidIDEOfficial:main Oct 3, 2022
@itsaky
Copy link
Member

itsaky commented Oct 3, 2022

Thanks for your contribution.

@Devendra34
Copy link
Contributor Author

Thanks for the awesome repository!
Happy coding!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
hacktoberfest-accepted Indicates that a PR was accepted as part of the Hacktoberfest event.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hide all editor windows when focus is changed from the editor
2 participants
@Devendra34 @itsaky