Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add MessageActionRow components in MessageObject #422

Merged
merged 29 commits into from
Mar 5, 2022
Merged

feat: add MessageActionRow components in MessageObject #422

merged 29 commits into from
Mar 5, 2022

Conversation

imranbarbhuiya
Copy link
Contributor

@imranbarbhuiya imranbarbhuiya commented Jan 25, 2022

Changes

This pr adds a new option for components in MessageObject

Status

  • These changes have been tested and formatted properly.
  • This PR includes only documentation changes (JSDoc, README or typings), no code change.
  • This PR introduces some breaking changes.

@imranbarbhuiya imranbarbhuiya marked this pull request as draft January 25, 2022 03:58
@imranbarbhuiya imranbarbhuiya marked this pull request as ready for review February 8, 2022 02:23
@Nico105 Nico105 added the enhancement New feature or request label Feb 8, 2022
@Nico105
Copy link
Collaborator

Nico105 commented Feb 16, 2022

Combining the embed readme part with this one would maybe be better and then naming it smth like "More message options" or "Message customizations".

Also maybe filling in linkURL or what its name is* would be good if someone wants to link to the gaw without editing the message after start()

@Nico105 Nico105 closed this Feb 16, 2022
@Nico105 Nico105 reopened this Feb 16, 2022
@Nico105
Copy link
Collaborator

Nico105 commented Feb 16, 2022

finger slipped

@imranbarbhuiya
Copy link
Contributor Author

imranbarbhuiya commented Feb 16, 2022

Also maybe filling in linkURL or what its name is* would be good if someone wants to link to the gaw without editing the message after start()

I've changed the code to allow linkbutton and selectmenu.

I've tested both type of buttons and they are working fine. I didn't tested selectmenu I'll test when i'll get time or u can test it.

@imranbarbhuiya
Copy link
Contributor Author

I'm not that good at wording. Please change it to whatever will suit.

@Nico105
Copy link
Collaborator

Nico105 commented Feb 16, 2022

both blocks are referring to winMessage...
But anyway, we would need such a block for noWinnerMessage and error of rerroll too.
So lets just make it a fillInComponents function, no?

@imranbarbhuiya
Copy link
Contributor Author

both blocks are referring to winMessage...
But anyway, we would need such a block for noWinnerMessage and error of rerroll too.
So lets just make it a fillInComponents function, no?

I've updated the code to allow no winner messages also.

src/Giveaway.js Outdated Show resolved Hide resolved
@Nico105
Copy link
Collaborator

Nico105 commented Feb 25, 2022

we would have to add | MessageActionRowOptions too right?
Cause it's at least guaranteed through serialization in case of winMessage.
(function behaviour doesn't change)

@imranbarbhuiya
Copy link
Contributor Author

we would have to add | MessageActionRowOptions too right? Cause it's at least guaranteed through serialization in case of winMessage. (function behaviour doesn't change)

added

@imranbarbhuiya
Copy link
Contributor Author

I just realized I need to create a new instance for action row or it'll change all the {} to a value and it won't get changed in the next fillInComponent. I'll fix it later.

@imranbarbhuiya imranbarbhuiya changed the title feat: add component in winMessage feat: add MessageActionRow components in MessageObject Feb 26, 2022
when a message/embed gets split because of its length, the components should get sent last
Copy link
Collaborator

@Nico105 Nico105 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be fine right?

@imranbarbhuiya
Copy link
Contributor Author

should be fine right?

Yeah.

@Nico105 Nico105 merged commit fdeaf51 into Androz2091:develop Mar 5, 2022
@Nico105
Copy link
Collaborator

Nico105 commented Mar 5, 2022

👍

@imranbarbhuiya imranbarbhuiya deleted the component branch March 6, 2022 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request semver:minor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants