Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: export Giveaway class #444

Merged
merged 1 commit into from
Mar 20, 2022
Merged

chore: export Giveaway class #444

merged 1 commit into from
Mar 20, 2022

Conversation

imranbarbhuiya
Copy link
Contributor

Changes

Export Giveaway class.

Why?

  • You can now extend start method where Giveaway class is needed.
  • You can now use a custom Manager with the giveaway class.
  • You can extend Giveaway class to do any changes and then use it in GiveawayManager#start to use extended Giveaway class.

Status

  • These changes have been tested and formatted properly.
  • This PR includes only documentation changes (JSDoc, README or typings), no code change.
  • This PR introduces some breaking changes.

@Nico105
Copy link
Collaborator

Nico105 commented Mar 20, 2022

alright, but for the record I have to say: people who change too much in it will be on their own for bug fixing.

@Nico105 Nico105 merged commit 4ddcf4e into Androz2091:develop Mar 20, 2022
@Nico105 Nico105 added enhancement New feature or request semver:minor labels Mar 20, 2022
@imranbarbhuiya imranbarbhuiya deleted the export branch March 20, 2022 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request semver:minor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants