🐛 Check if embed was edited on end() #462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hope this goes well, otherwise revert and thinking of a new approach XD |
Nico105
added a commit
that referenced
this pull request
Jul 7, 2022
This reverts commit 5be503f. This was done because of issues with the checking system/the while loop. It seems there are unknown factors/errors which will trigger the while loop rejection "could not get edited" unfortunately this will leave the issue of not editing giveaways in its former state
|
didn't go well => will have reconsider the approach |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Added private
isEndingproperty which makes sure thatendedis only true if the giveaway embed was successfully edited.The only thing that isn't checked is wheter all win Messages were sent. But checking that would require too much fetching, so it's not worth it. It's most important that the embed is properly edited.
Status