Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make youtube bridge work only when YoutubeExtractor is registered #1789

Closed
twlite opened this issue Aug 1, 2023 · 4 comments
Closed

Make youtube bridge work only when YoutubeExtractor is registered #1789

twlite opened this issue Aug 1, 2023 · 4 comments
Assignees
Labels
area:extractor Extractors related develop:resolved enhancement New feature or request

Comments

@twlite
Copy link
Collaborator

twlite commented Aug 1, 2023

SoundCloud bridge only works when SoundCloudExtractor is registered but it is not the case for YouTube bridge.

YouTube bridge should only work when there is youtube extractor available. If there is no youtube extractor, an extractor may fall back to loading soundcloud if it is available. If both of them are not available, it should throw an error.

This should not be considered as a breaking change, and it would encourage people to use what they prefer.

For compatibility reasons, it should first load youtube bridge and then fall back to soundcloud unless explicitly specified.

I do not expect any code changes after this update on the users side.

This would also make it easier to not include youtube playback on one's bot if needed, which is already possible though. https://discord-player.js.org/guide/faq/disable-youtube

@twlite twlite added the enhancement New feature or request label Aug 1, 2023
@twlite twlite self-assigned this Aug 1, 2023
@twlite twlite added the area:extractor Extractors related label Aug 1, 2023
@LackyPal
Copy link
Contributor

LackyPal commented Aug 1, 2023

Can we add a 3rd extract if YouTube and SoundCloud both failed? Or specify which extractor to use first ?

@retrouser955
Copy link
Contributor

Can we add a 3rd extract if YouTube and SoundCloud both failed? Or specify which extractor to use first ?

Currently, the only stream providers we know of are YouTube and SoundCloud. Feel free to list the one you know.

@LackyPal
Copy link
Contributor

I made a hungama-music downloader. Check it. Though there's some bug, but the APIs are working. You can make a hungama-music extractor.

Jiosaavn also support stream. There's not any npm package, but there's some api scrapers. Hope you will make a extractor for JioSaavn too.

@twlite
Copy link
Collaborator Author

twlite commented Aug 15, 2023

I made a hungama-music downloader. Check it. Though there's some bug, but the APIs are working. You can make a hungama-music extractor.

Jiosaavn also support stream. There's not any npm package, but there's some api scrapers. Hope you will make a extractor for JioSaavn too.

We dont have plans on introducing yet another extractor to our maintenance list at the moment. You can release your own extractor package. See https://discord-player.js.org/guide/extractors/creating-extractor for more info.

@twlite twlite closed this as completed Sep 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:extractor Extractors related develop:resolved enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants