fix: shorthand should only reject once

AndyOGo · May 19, 2020 · ce46c63 · ce46c63
1 parent 9e4fd98
commit ce46c63
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/src/index.js b/src/index.js
@@ -143,12 +143,13 @@ const ruleFunction = (properties, options, context = {}) => (root, result) => {
         lintDeclStrictValue(node)
       } else if (isShortHand) {
         const expandedProps = shortCSS.expand(prop, value, recurseLonghand)
+        let failedFlag = false
 
         Object.keys(expandedProps).forEach((longhandProp) => {
           const longhandValue = expandedProps[longhandProp]
 
-          if (longhandProp === propFilter || (propFilter instanceof RegExp && propFilter.test(longhandProp))) {
-            lintDeclStrictValue(node, longhandProp, longhandValue)
+          if (!failedFlag && (longhandProp === propFilter || (propFilter instanceof RegExp && propFilter.test(longhandProp)))) {
+            failedFlag = lintDeclStrictValue(node, longhandProp, longhandValue)
           }
         })
       }
@@ -252,6 +253,8 @@ const ruleFunction = (properties, options, context = {}) => (root, result) => {
             message: messages.expected(types, value, nodeProp, message),
           })
         }
+
+        return true
       }
     }
   })