fix: only execute autofix func if it could be found

AndyOGo · Apr 2, 2021 · f5b20e3 · f5b20e3
1 parent d71d199
commit f5b20e3
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 2 deletions.
diff --git a/src/index.ts b/src/index.ts
@@ -428,8 +428,8 @@ const ruleFunction: StylelintRuleFunction = (
         const types = getTypes(config, property);
 
         // support auto fixing
-        if (context.fix && !disableFix) {
-          const fixedValue = autoFixFuncNormalized!(
+        if (context.fix && !disableFix && autoFixFuncNormalized) {
+          const fixedValue = autoFixFuncNormalized(
             node,
             {
               validVar,

diff --git a/test/auto-fix-func.js b/test/auto-fix-func.js
@@ -8,6 +8,34 @@ const { rule } = declarationStrictValue;
 const ruleWithContext = (context) => (properties, options) =>
   rule(properties, options, context);
 
+// works if autofix is omitted
+testRule(
+  ruleWithContext({
+    fix: true,
+  }),
+  {
+    ruleName,
+    skipBasicChecks: true,
+
+    config: ['color'],
+
+    reject: [
+      {
+        code: '.foo { color: #fff; }',
+        message: `Expected variable or function for "#fff" of "color" (${ruleName})`,
+        line: 1,
+        column: 8,
+      },
+      {
+        code: '.foo { color: red; }',
+        message: `Expected variable or function for "red" of "color" (${ruleName})`,
+        line: 1,
+        column: 8,
+      },
+    ],
+  }
+);
+
 // autofix by function property
 testRule(
   ruleWithContext({