Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Question: it is neccessary to output console.error(error, messages.failedToFix(...)) in catch of autoFixFunc ? #276

Closed
voskresla opened this issue Oct 13, 2022 · 2 comments · Fixed by #277
Closed

Question: it is neccessary to output console.error(error, messages.failedToFix(...)) in catch of autoFixFunc ? #276

voskresla opened this issue Oct 13, 2022 · 2 comments · Fixed by #277
Assignees
@AndyOGo
Labels
bug

Comments

@voskresla
Copy link

voskresla commented Oct 13, 2022 •
edited

With this lines we get additional console error besides the report. When we pass throw null we get this null before default error

stylelint-declaration-strict-value/src/index.ts

Lines 442 to 445 in fc66294

console.error(
error,
messages.failedToFix(error, value, nodeProp)
); 

'scale-unlimited/declaration-strict-value': ['z-index', { 
    ignoreFunctions: false, 
    autoFixFunc: () => { throw null } 
}],

image
@AndyOGo
Copy link
Owner

AndyOGo commented Oct 13, 2022 •
edited

That is unnecessary, yes

@AndyOGo AndyOGo closed this as completed Oct 13, 2022
@AndyOGo AndyOGo reopened this Oct 13, 2022
@AndyOGo AndyOGo added bug and removed question labels Oct 13, 2022
AndyOGo added a commit that referenced this issue Oct 13, 2022
@AndyOGo
fix: #276 remove console.error
9f9a59d
@AndyOGo AndyOGo mentioned this issue Oct 13, 2022
Merged
@AndyOGo AndyOGo self-assigned this Oct 13, 2022
AndyOGo added a commit that referenced this issue Oct 13, 2022
@AndyOGo
Merge pull request #277 from AndyOGo/bugfix/276-remove-console-error
e79311f 
fix: #276 remove console.error
AndyOGo pushed a commit that referenced this issue Oct 13, 2022
@semantic-release-bot
chore(release): 1.9.1 [skip ci]
f50dfc5 
## [1.9.1](v1.9.0...v1.9.1) (2022-10-13)

### Bug Fixes

* [#276](#276) remove console.error ([9f9a59d](9f9a59d))
@AndyOGo
Copy link
Owner

AndyOGo commented Oct 13, 2022

@voskresla
Thanks a lot for the issue.

I removed it an released v1.9.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AndyOGo AndyOGo

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: #276 remove console.error AndyOGo/stylelint-declaration-strict-value
2 participants
@AndyOGo @voskresla