Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Also run Github actions on PRs #615

Merged
merged 2 commits into from Feb 26, 2024
Merged

Also run Github actions on PRs #615

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9d99beb
Documentation changes v0.9.2 (#610)
AndyTheFactory Jan 17, 2024
d5d308c
build: Also run Github actions on PRs
palfrey Feb 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/pipeline.yml
View file
Open in desktop
Expand Up @@ -4,6 +4,7 @@ on: # events that trigger our pipeline: push on any branch and release creation
push:
release:
types: [created]
pull_request:

jobs: # jobs. We will have two jobs (test and publish) with multiple steps.
test:
Expand Down
4 changes: 3 additions & 1 deletion .github/workflows/pylint.yml
View file
Open in desktop
@@ -1,6 +1,8 @@
name: Pylint

on: [push]
on:
push:
pull_request:

jobs:
build:
Expand Down
4 changes: 2 additions & 2 deletions CONTRIBUTING.md
View file
Open in desktop
Expand Up @@ -126,8 +126,8 @@ source venv/bin/activate
# Upgrade pip (very important!)
pip install --upgrade pip

# Install Newspaper3k in editable mode
pip install -e '.[dev]'
# Install Newspaper4k in editable mode
pip install -e '.'
```

Last, install the pre-commit hooks with:
Expand Down