Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add license to Cargo.toml #29

Merged
merged 2 commits into from Sep 25, 2022
Merged

Add license to Cargo.toml #29

merged 2 commits into from Sep 25, 2022

Conversation

bernardofcordeiro
Copy link
Contributor

MR adds license metadata to package

@Anexen
Copy link
Owner

Anexen commented Sep 24, 2022

@bernardofcordeiro, thank you for the contribution!
Please also add the classifier: License :: OSI Approved :: The Unlicense (Unlicense)

@bernardofcordeiro
Copy link
Contributor Author

@bernardofcordeiro, thank you for the contribution! Please also add the classifier: License :: OSI Approved :: The Unlicense (Unlicense)

Added as proposed

@Anexen Anexen merged commit c075b9f into Anexen:main Sep 25, 2022
@bernardofcordeiro
Copy link
Contributor Author

@Anexen can you publish this to PyPI?

@Anexen
Copy link
Owner

Anexen commented Sep 28, 2022

@bernardofcordeiro, is it critical for you? pypi does not provide the ability to modify the project metadata without uploading the whole package. Releasing the next version for the sake of changing metadata doesn't look natural to me. Overwriting the current version will probably change the hash and lead to issues with tools like poetry.

@bernardofcordeiro
Copy link
Contributor Author

@Anexen I found this pkg and works perfectly, but unfortunately our license checker throws an error since it can't assess which license the package has, and therefore our builds fail.
We can temporarily override the package license checker for now, so this is not very urgent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants