Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Null coalescing #1

Closed
tonymrakovcic opened this issue Dec 6, 2022 · 1 comment · Fixed by #2
Closed

Null coalescing #1

tonymrakovcic opened this issue Dec 6, 2022 · 1 comment · Fixed by #2
Assignees
Labels
bug Something isn't working

Comments

@tonymrakovcic
Copy link

Hello,
It's kind of weird but I wanted to ask what you think.

Due to some hardware limitations (using embedded hardware that has to support old versions since it is in the wilderness) my limitation is node 12.
Null coalescing has arrived in node in version > 14
When trying to make an exe with node12 I get an error on coalescing on this line

const args = [options.entry, ...(options.pkg ?? []), '-t', options.target ?? 'latest-win-x64', '-o', options.out];

I tried to just edit it out and then everything works :D

    const args = [options.entry, ...(options.pkg !== undefined ? options.pkg : []), '-t', options.target  !== undefined ? options.target : 'latest-win-x64', '-o', options.out];

I was wondering if this would be possible on your side so it can be used as part of the CI and npm install, and for your great package to support node 12

I am happy to create the PR etc

Thanks!

@AngaBlue
Copy link
Owner

AngaBlue commented Dec 6, 2022

For sure, I'll update the target flavour of JavaScript in the tsconfig to support node 12.

@AngaBlue AngaBlue self-assigned this Dec 6, 2022
@AngaBlue AngaBlue added the bug Something isn't working label Dec 6, 2022
@AngaBlue AngaBlue linked a pull request Dec 6, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants