Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] issue #9 - Add activity indicator while loading motels data from Azure #13

Conversation

RicardoBritoBrens
Copy link
Contributor

If anyone want to test i recommend to use Delay method of the Task class like this.

Task.Delay(9000); // millisecondsDelay

Resources use to solve the issue:

https://github.com/aritchie/userdialogs

It's working!!!!!!!!!!!
Issue #9 done

@RicardoBritoBrens RicardoBritoBrens changed the title [FIX] Issue #9 - Add activity indicator while loading motels data from Azure [FIX] issue #9 - Add activity indicator while loading motels data from Azure Aug 16, 2020
Copy link
Owner

@AngelGarcia13 AngelGarcia13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR! Te hice un review para que veas unas cuantas cositas, gracias bro!

src/App/CabanasRD/CabanasRD.csproj Outdated Show resolved Hide resolved
src/CabanasRD.sln Outdated Show resolved Hide resolved
@Pujolsluis Pujolsluis self-requested a review August 21, 2020 21:18
Copy link
Collaborator

@Pujolsluis Pujolsluis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @RicardoBritoBrens ! everything looks good to go, we need you to pull the latest changes and resolve the new conflicts.

src/App/CabanasRD.Android/CabanasRD.Android.csproj Outdated Show resolved Hide resolved
@RicardoBritoBrens
Copy link
Contributor Author

Conflicts solved, thanks Mr. @AngelGarcia13 and Mr.@Pujolsluis for your comments

src/App/CabanasRD.Android/CabanasRD.Android.csproj Outdated Show resolved Hide resolved
src/App/CabanasRD/Messages/DisplayAlertCommonMessages.cs Outdated Show resolved Hide resolved
src/App/MotelsMapPageViewModel.cs Outdated Show resolved Hide resolved
@AngelGarcia13 AngelGarcia13 merged commit 351a87b into AngelGarcia13:master Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants