Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn when perla-esbuild-plugin is not present in the plugins list #115

Closed
AngelMunoz opened this issue Apr 14, 2023 · 1 comment
Closed
Labels
1.x Issues made for v1 preview versions enhancement New feature or request good first issue Good for newcomers in-dev The item has been worked and can be found in the dev branch

Comments

@AngelMunoz
Copy link
Owner

Is your feature request related to a problem? Please describe.

We should show a console warning (and a way to disable it) when the esbuild plugin is not part of the configuration's plugin list.

the esbuild plugin is not really necessary as someone can create their own plugin to replace the same functionality however if no replacement is provided then the core-functionality in perla is affected

Describe the solution you'd like

Show a message in the console to warn the user that they took out a core plugin from the list

Describe alternatives you've considered
N/A

Additional context

Taken from #113

@AngelMunoz AngelMunoz added enhancement New feature or request good first issue Good for newcomers 1.x Issues made for v1 preview versions labels Apr 14, 2023
AngelMunoz added a commit that referenced this issue Apr 15, 2023
@AngelMunoz
Copy link
Owner Author

I double checked that the schema warns you if you don't provide the default esbuild plugin and we also now show a warning in console when the plugin is missing for any particular reason

@AngelMunoz AngelMunoz added the in-dev The item has been worked and can be found in the dev branch label Apr 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x Issues made for v1 preview versions enhancement New feature or request good first issue Good for newcomers in-dev The item has been worked and can be found in the dev branch
Projects
Status: Done
Development

No branches or pull requests

1 participant