Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BaseRequester events do not properly remove event handlers #572

Closed
ArcanoxDragon opened this issue Jun 14, 2017 · 1 comment
Closed

BaseRequester events do not properly remove event handlers #572

ArcanoxDragon opened this issue Jun 14, 2017 · 1 comment
Labels
bug help-wanted requester
Milestone
v0.10

Comments

@ArcanoxDragon
Copy link
Contributor

In the devel branch, the events defined in AngleSharp.Io.BaseRequester do not correctly remove event handlers when delegates are removed from the .NET events. On BaseRequester.cs:20 and BaseRequester.cs:29, the remove handler incorrectly calls AddEventListener again instead of calling RemoveEventListener.
ArcanoxDragon added a commit to ArcanoxDragon/AngleSharp that referenced this issue Jun 14, 2017
@ArcanoxDragon
Fixes AngleSharp#572
5c3dab8
FlorianRappl added a commit that referenced this issue Jun 14, 2017
@FlorianRappl
Merge pull request #573 from briman0094/devel
014916c 
Fixes #572
@FlorianRappl
Copy link
Contributor

Very good finding - thanks for the PR!

@FlorianRappl FlorianRappl added this to the v0.10 milestone Jun 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug help-wanted requester
Projects
None yet
Milestone
v0.10
Development

No branches or pull requests
2 participants
@ArcanoxDragon @FlorianRappl