Fixed the loading of link element source #1185
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of Changes
Prerequisites
Please make sure you can check the following two boxes:
Contribution Type
What types of changes does your code introduce? Put an
x
in all the boxes that apply:Description
This is a fix for #1184
The issue was that the
_relation
variable was only set during theSetupElement
method. But when adding a new link element therel
attribute is often not set at this point. So ifrel
andhref
are set after creation it will never call_relation?.LoadAsync()
, and therefore the resource loader won't kick in.Changes:
HtmlLinkElement
to make sure that it attempts to load the relation when either therel
,href
attributes have changed, or when the parent has changed (i.e. when it's added to the document). I took inspiration from theHtmlScriptElement
where something similar happens.DefaultAttributeObserver
to trigger the newUpdateRel
method when therel
attribute changes.