updated for godot 4, and added support for AudioStream2d, 3d, and Spr… #13
Conversation
|
Wow. I appreciate your work. Sorry you had to face my beginner's code. |
|
Haha. I didn't realise it was "beginner" code. It taught me to use yield aka await. I never use yield, and it solves a lot of editor plugin problems.. Yes! What's the easiest way for me to make this a branch? I actually still struggle with git a little :p this is my first actual pr ever! :P |
|
It's the first addon I made so there might be some things I'd write differently and approaches I wouldn't take. Sometimes I use https://gitexplorer.com/ when I forget a command. |
|
So do I just branch on my end and then post it as a pr? Don't I have to specify which branch the pr is for on your end? |
|
P.s. the plugin is great! :) So simple yet so effective. Gonna save me a lot of lipsync time. |
|
Oh. Didn't come to me at first that you meant to pr the branch. I only messed with PRs once so I do not know the command to do so. Maybe there's options to change the target branch on the github site? But you shouldn't expect it'll be soon to merge because I'd have to wait for a godot4 fork with gles2/3 to test it. Realtime is impossible because rhubarb needs some time to process the audio. But runtime was actually a scope-creep goal I had at the beginning, though didn't find a use for it so shelved. |
|
@AniMesuro As now Godot 4 comes with a GLES backend, have you got any plan for testing and merging this? |
|
@floppyhammer Unfortunately not. I still use only Godot3 so I'll have to relearn gdscript from Godot4 to finally update the addon. |
|
I didn't put a lot of time into it, so don't worry about my contribution :)
I also think godot4 gdscript has changed a bit since I made this pr. I
actually find it SO much more enjoyable than the original gdscript. Would
highly recommend learning. Didn't take me long at all to switch, and the
new features make life much better :)
If there's any way I can help let me know :) I haven't looked into lipsync
technology lately, but I think this might still be the best option for
godot users. Would love to have a real-time/run-time version of this for
multiplayer experiences.
…On Thu, Aug 24, 2023, 1:31 p.m. AniMesuro ***@***.***> wrote:
Unfortunately not. I still use only Godot3 so I'll have to relearn
gdscript from Godot4 to finally update the addon.
Although I do want to honour rossunger's contribution, so eventually it's
possible for me to set time for studying when I get free-ish time from my
job.
—
Reply to this email directly, view it on GitHub
<#13 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACGZ2R2SOMW63A7ANQUNYHDXW6FV3ANCNFSM5OWPPSWA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***
.com>
|
|
Still waiting to see an update so i can test out an idea i had with this addon 👀 |
|
Hey all, unfortunately it looks like this PR is no longer working in Godot 4. I'd really love to be able to use this as I seem to have pretty much 0 other options available for Godot 4! |
Same. It seems majority of the systems need a rewrite with new contributors, Maybe using reddit/alt platforms can redirect them. (I hope 3d lip syncing gets added if this happens!) |
|
i've decided to create my own derivative of this plugin for godot 4.2+. it's still early on in it's development, but is in a usable state. If you want to check it out, here's a link to it https://github.com/Pheubel/Rhubarb-Lip-Sync-Tool-for-Godot-4 |
updated for godot 4 and gdscript 2, and added support for AudioStream2d, 3d, and Sprite3D